From: Jakub Kicinski <kuba@kernel.org>
To: Yevgeny Kliteynik <kliteyn@nvidia.com>
Cc: Simon Horman <horms@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
saeedm@nvidia.com, gal@nvidia.com, leonro@nvidia.com,
tariqt@nvidia.com, Leon Romanovsky <leon@kernel.org>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, moshe@nvidia.com,
Vlad Dogaru <vdogaru@nvidia.com>
Subject: Re: [PATCH net-next v2 3/8] net/mlx5: HWS, Refactor and export rule skip logic
Date: Tue, 24 Jun 2025 17:45:24 -0700 [thread overview]
Message-ID: <20250624174524.62bc82e6@kernel.org> (raw)
In-Reply-To: <dff4ea02-4adc-4044-a18a-ee884abc0053@nvidia.com>
On Wed, 25 Jun 2025 03:35:52 +0300 Yevgeny Kliteynik wrote:
> >> The bwc layer will use `mlx5hws_rule_skip` to keep track of numbers of
> >> RX and TX rules individually, so export this function for future usage.
> >>
> >> While we're in there, reduce nesting by adding a couple of early return
> >> statements.
> >
> > I'm all for reducing nesting. But this patch has two distinct changes.
> > Please consider splitting it into two patches.
>
> Not sure I'd send the refactor thing alone - it isn't worth the effort
> IMHO... But since I'm already in here - sure, will sent it in a separate
> patch.
FWIW having a function which returns void but with 2 output parameters
is in itself a bit awkward. I'd personally return a 2 bit bitmask of
which mode is enabled. But there's no accounting for taste.
next prev parent reply other threads:[~2025-06-25 0:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-22 17:22 [PATCH net-next v2 0/8] net/mlx5: HWS, Optimize matchers ICM usage Mark Bloch
2025-06-22 17:22 ` [PATCH net-next v2 1/8] net/mlx5: HWS, remove unused create_dest_array parameter Mark Bloch
2025-06-24 18:37 ` Simon Horman
2025-06-22 17:22 ` [PATCH net-next v2 2/8] net/mlx5: HWS, remove incorrect comment Mark Bloch
2025-06-24 18:37 ` Simon Horman
2025-06-22 17:22 ` [PATCH net-next v2 3/8] net/mlx5: HWS, Refactor and export rule skip logic Mark Bloch
2025-06-24 18:38 ` Simon Horman
2025-06-25 0:35 ` Yevgeny Kliteynik
2025-06-25 0:45 ` Jakub Kicinski [this message]
2025-06-25 14:42 ` Yevgeny Kliteynik
2025-06-25 9:45 ` Simon Horman
2025-06-25 13:41 ` Yevgeny Kliteynik
2025-06-22 17:22 ` [PATCH net-next v2 4/8] net/mlx5: HWS, Create STEs directly from matcher Mark Bloch
2025-06-24 18:57 ` Simon Horman
2025-06-22 17:22 ` [PATCH net-next v2 5/8] net/mlx5: HWS, Decouple matcher RX and TX sizes Mark Bloch
2025-06-24 18:57 ` Simon Horman
2025-06-22 17:22 ` [PATCH net-next v2 6/8] net/mlx5: HWS, Track matcher sizes individually Mark Bloch
2025-06-22 17:22 ` [PATCH net-next v2 7/8] net/mlx5: HWS, Shrink empty matchers Mark Bloch
2025-06-25 0:08 ` Jakub Kicinski
2025-06-25 14:42 ` Yevgeny Kliteynik
2025-06-22 17:22 ` [PATCH net-next v2 8/8] net/mlx5: Add HWS as secondary steering mode Mark Bloch
2025-06-22 22:39 ` [PATCH net-next v2 0/8] net/mlx5: HWS, Optimize matchers ICM usage Zhu Yanjun
2025-06-23 12:03 ` Mark Bloch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250624174524.62bc82e6@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=kliteyn@nvidia.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=vdogaru@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.