From: Christoph Hellwig <hch@lst.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, kbusch@kernel.org,
sagi@grimberg.me, hare@suse.de, dwagner@suse.de, axboe@kernel.dk,
shinichiro.kawasaki@wdc.com, gjoyce@ibm.com
Subject: Re: [PATCH 1/1] nvme: correctly account for namespace head reference counter
Date: Wed, 25 Jun 2025 08:10:40 +0200 [thread overview]
Message-ID: <20250625061040.GA9457@lst.de> (raw)
In-Reply-To: <a16bceaa-cb73-4d23-b145-25d5bc74eded@linux.ibm.com>
On Tue, Jun 24, 2025 at 07:54:29PM +0530, Nilay Shroff wrote:
> Thanks! I'd update the above typo, however today I was testing some code
> after disabling CONFIG_NVME_MULTIPATH and I realized that although the
> namespace head (ns->head) is still created, its associated head->disk is
> not initialized in this configuration.
Yes.
> So I'll send out patchv2 with the above changes.
Thanks! Please also add a comment to nvme_alloc_ns as the logic is
fairly complex now and future readers will benefit from an explanation.
next prev parent reply other threads:[~2025-06-25 6:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 8:02 [PATCH 1/1] nvme: correctly account for namespace head reference counter Nilay Shroff
2025-06-23 8:18 ` Daniel Wagner
2025-06-24 13:30 ` Nilay Shroff
2025-06-24 13:42 ` Daniel Wagner
2025-06-23 12:20 ` Christoph Hellwig
2025-06-24 14:24 ` Nilay Shroff
2025-06-25 6:10 ` Christoph Hellwig [this message]
2025-06-25 6:12 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250625061040.GA9457@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=gjoyce@ibm.com \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.