From: Leon Romanovsky <leon@kernel.org>
To: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: Yury Norov <yury.norov@gmail.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] RDMA: hfi1: cpumasks usage fixes
Date: Wed, 25 Jun 2025 13:41:13 +0300 [thread overview]
Message-ID: <20250625104113.GE17401@unreal> (raw)
In-Reply-To: <ed72aae3-e9c2-4768-a400-cb99cb2a0f24@cornelisnetworks.com>
On Mon, Jun 23, 2025 at 12:23:36PM -0400, Dennis Dalessandro wrote:
> On 6/21/25 11:03 AM, Yury Norov wrote:
> > On Thu, Jun 12, 2025 at 11:12:29AM +0300, Leon Romanovsky wrote:
> >> On Wed, Jun 04, 2025 at 03:39:36PM -0400, Yury Norov wrote:
> >>> The driver uses cpumasks API in a non-optimal way; partially because of
> >>> absence of proper functions. Fix this and nearby logic.
> >>>
> >>> Yury Norov [NVIDIA] (7):
> >>> cpumask: add cpumask_clear_cpus()
> >>> RDMA: hfi1: fix possible divide-by-zero in find_hw_thread_mask()
> >>> RDMA: hfi1: simplify find_hw_thread_mask()
> >>> RDMA: hfi1: simplify init_real_cpu_mask()
> >>> RDMA: hfi1: use rounddown in find_hw_thread_mask()
> >>> RDMA: hfi1: simplify hfi1_get_proc_affinity()
> >>> RDMI: hfi1: drop cpumask_empty() call in hfi1/affinity.c
> >>>
> >>> drivers/infiniband/hw/hfi1/affinity.c | 96 +++++++++++----------------
> >>> include/linux/cpumask.h | 12 ++++
> >>> 2 files changed, 49 insertions(+), 59 deletions(-)
> >>
> >> Dennis?
> >
> > So?.. Any feedback?
>
> I'm ambivalent about this patch series. It looks OK but I don't think it's
> really fixing anything.
Yeas, I applied because more code was deleted than added.
next prev parent reply other threads:[~2025-06-25 10:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 19:39 [PATCH 0/7] RDMA: hfi1: cpumasks usage fixes Yury Norov
2025-06-04 19:39 ` [PATCH 1/7] cpumask: add cpumask_clear_cpus() Yury Norov
2025-06-04 19:39 ` [PATCH 2/7] RDMA: hfi1: fix possible divide-by-zero in find_hw_thread_mask() Yury Norov
2025-06-04 19:39 ` [PATCH 3/7] RDMA: hfi1: simplify find_hw_thread_mask() Yury Norov
2025-06-04 19:39 ` [PATCH 4/7] RDMA: hfi1: simplify init_real_cpu_mask() Yury Norov
2025-06-04 19:39 ` [PATCH 5/7] RDMA: hfi1: use rounddown in find_hw_thread_mask() Yury Norov
2025-06-04 19:39 ` [PATCH 6/7] RDMA: hfi1: simplify hfi1_get_proc_affinity() Yury Norov
2025-06-04 19:39 ` [PATCH 7/7] RDMI: hfi1: drop cpumask_empty() call in hfi1/affinity.c Yury Norov
2025-06-12 8:12 ` [PATCH 0/7] RDMA: hfi1: cpumasks usage fixes Leon Romanovsky
2025-06-21 15:03 ` Yury Norov
2025-06-23 16:23 ` Dennis Dalessandro
2025-06-25 10:41 ` Leon Romanovsky [this message]
2025-06-25 10:41 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250625104113.GE17401@unreal \
--to=leon@kernel.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.