Re: [PATCH net-next v2 8/8] selftests: drv-net: test RSS Netlink notifications

[Jakub Kicinski <kuba@kernel.org>]

On Wed, 25 Jun 2025 10:46:53 +0100 Donald Hunter wrote:
> > +def _ethtool_create(cfg, act, opts):
> > +    output = ethtool(f"{act} {cfg.ifname} {opts}").stdout
> > +    # Output will be something like: "New RSS context is 1" or
> > +    # "Added rule with ID 7", we want the integer from the end
> > +    return int(output.split()[-1])  
> 
> I think .split() is not required because you can access strings as
> arrays.
> 
> Will this only ever need to handle single digit values?

nosir, IIUC split splits on whitespace, so from:

	"Added rule with ID 7"  -> [.."ID", "7"]
	"Added rule with ID 71" -> [.."ID", "71"]

and we take the last elem, the ID. We use similar code in the rss_ctx
test, I think it works..

Unfortunately there is no plan to migrate the flow steering to netlink.
And ethtool only supports JSON output in the netlink code :S
Mountains of technical debt :)