From: Will Deacon <will@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: "Will Deacon" <will@kernel.org>, "Keir Fraser" <keirf@google.com>,
"Steven Moreland" <smoreland@google.com>,
"Frederick Mayle" <fmayle@google.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
netdev@vger.kernel.org, virtualization@lists.linux.dev
Subject: [PATCH 2/5] vsock/virtio: Resize receive buffers so that each SKB fits in a page
Date: Wed, 25 Jun 2025 14:15:40 +0100 [thread overview]
Message-ID: <20250625131543.5155-3-will@kernel.org> (raw)
In-Reply-To: <20250625131543.5155-1-will@kernel.org>
When allocating receive buffers for the vsock virtio RX virtqueue, an
SKB is allocated with a 4140 data payload (the 44-byte packet header +
VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE). Even when factoring in the SKB
overhead, the resulting 8KiB allocation thanks to the rounding in
kmalloc_reserve() is wasteful (~3700 unusable bytes) and results in a
higher-order page allocation for the sake of a few hundred bytes of
packet data.
Limit the vsock virtio RX buffers to a page per SKB, resulting in much
better memory utilisation and removing the need to allocate higher-order
pages entirely.
Signed-off-by: Will Deacon <will@kernel.org>
---
include/linux/virtio_vsock.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h
index 36fb3edfa403..67ffb64325ef 100644
--- a/include/linux/virtio_vsock.h
+++ b/include/linux/virtio_vsock.h
@@ -111,7 +111,8 @@ static inline size_t virtio_vsock_skb_len(struct sk_buff *skb)
return (size_t)(skb_end_pointer(skb) - skb->head);
}
-#define VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE (1024 * 4)
+#define VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE (SKB_WITH_OVERHEAD(PAGE_SIZE) \
+ - VIRTIO_VSOCK_SKB_HEADROOM)
#define VIRTIO_VSOCK_MAX_BUF_SIZE 0xFFFFFFFFUL
#define VIRTIO_VSOCK_MAX_PKT_BUF_SIZE (1024 * 64)
--
2.50.0.714.g196bf9f422-goog
next prev parent reply other threads:[~2025-06-25 13:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 13:15 [PATCH 0/5] vsock/virtio: SKB allocation improvements Will Deacon
2025-06-25 13:15 ` [PATCH 1/5] vhost/vsock: Avoid allocating arbitrarily-sized SKBs Will Deacon
2025-06-27 10:36 ` Stefano Garzarella
2025-06-30 12:51 ` Will Deacon
2025-07-01 10:37 ` Stefano Garzarella
2025-06-25 13:15 ` Will Deacon [this message]
2025-06-27 10:41 ` [PATCH 2/5] vsock/virtio: Resize receive buffers so that each SKB fits in a page Stefano Garzarella
2025-06-30 13:06 ` Will Deacon
2025-06-25 13:15 ` [PATCH 3/5] vhost/vsock: Allocate nonlinear SKBs for handling large receive buffers Will Deacon
2025-06-27 10:45 ` Stefano Garzarella
2025-06-30 14:20 ` Will Deacon
2025-07-01 10:44 ` Stefano Garzarella
2025-07-01 13:52 ` Will Deacon
2025-06-25 13:15 ` [PATCH 4/5] vsock/virtio: Rename virtio_vsock_skb_rx_put() to virtio_vsock_skb_put() Will Deacon
2025-06-27 10:46 ` Stefano Garzarella
2025-06-25 13:15 ` [PATCH 5/5] vhost/vsock: Allocate nonlinear SKBs for handling large transmit buffers Will Deacon
2025-06-27 10:50 ` Stefano Garzarella
2025-06-30 14:21 ` Will Deacon
2025-06-27 10:51 ` [PATCH 0/5] vsock/virtio: SKB allocation improvements Stefano Garzarella
2025-06-30 12:50 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250625131543.5155-3-will@kernel.org \
--to=will@kernel.org \
--cc=eperezma@redhat.com \
--cc=fmayle@google.com \
--cc=jasowang@redhat.com \
--cc=keirf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=smoreland@google.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.