From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F2B9C77B7C for ; Wed, 25 Jun 2025 14:45:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D28E610E747; Wed, 25 Jun 2025 14:45:51 +0000 (UTC) Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 56B6010E747 for ; Wed, 25 Jun 2025 14:45:50 +0000 (UTC) Received: from trampoline.thunk.org (pool-173-48-82-219.bstnma.fios.verizon.net [173.48.82.219]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 55PEZxBr000389 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Jun 2025 10:36:00 -0400 Received: by trampoline.thunk.org (Postfix, from userid 15806) id 660662E00D5; Wed, 25 Jun 2025 10:35:59 -0400 (EDT) Date: Wed, 25 Jun 2025 10:35:59 -0400 From: "Theodore Ts'o" To: =?utf-8?B?6ZmI5rab5rab?= Taotao Chen Cc: "hch@infradead.org" , "adilger.kernel@dilger.ca" , "willy@infradead.org" , "brauner@kernel.org" , "jani.nikula@linux.intel.com" , "rodrigo.vivi@intel.com" , "tursulin@ursulin.net" , "airlied@gmail.com" , "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-block@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "chentao325@qq.com" Subject: Re: [PATCH v2 4/5] ext4: handle IOCB_DONTCACHE in buffered write path Message-ID: <20250625143559.GE28249@mit.edu> References: <20250624121149.2927-1-chentaotao@didiglobal.com> <20250624121149.2927-5-chentaotao@didiglobal.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250624121149.2927-5-chentaotao@didiglobal.com> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Jun 24, 2025 at 12:12:09PM +0000, 陈涛涛 Taotao Chen wrote: > From: Taotao Chen > > Add support for the IOCB_DONTCACHE flag in ext4_write_begin() and > ext4_da_write_begin(). When set in the kiocb, the FGP_DONTCACHE bit > is passed to the page cache lookup, preventing written pages from > being retained in the cache. > > Only the handling logic is implemented here; the behavior remains > inactive until ext4 advertises support via FOP_DONTCACHE. > > This change relies on prior patches that refactor the write_begin > interface to use struct kiocb and introduce DONTCACHE handling in ext4. > > Part of a series refactoring address_space_operations write_begin and > write_end callbacks to use struct kiocb for passing write context and > flags. > > Signed-off-by: Taotao Chen Acked-by: Theodore Ts'o