From: Trevor Woerner <twoerner@gmail.com>
To: yocto-patches@lists.yoctoproject.org
Cc: Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [yocto-patches] [meta-rockchip PATCH 0/2] bsp: rkbin: fix build issues around S and WORKDIR
Date: Wed, 25 Jun 2025 11:53:14 -0400 [thread overview]
Message-ID: <20250625155314.GA14662@localhost> (raw)
In-Reply-To: <20250625-s-unpackdir-v1-0-6f45466478d8@cherry.de>
On Wed 2025-06-25 @ 02:07:12 PM, Quentin Schulz via lists.yoctoproject.org wrote:
> Since commit 46480a5e6674 ("insane/do_qa_unpack: add checks that ensure
> S is set correctly"), three recipes fail to build because they either:
>
> - set S to WORKDIR/git which isn't allowed anymore for git-fetched
> recipes,
> - have WORKDIR in S which isn't allowed anymore, UNPACKDIR should be
> used instead,
>
> This fixes the build issues seen on master.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> ---
> Quentin Schulz (2):
> bsp: rkbin: fix build since S = "${WORKDIR}/git" is implied by OE-Core
> bsp: rkbin-native: fix build since ${WORKDIR} isn't allowed in S anymore
>
> recipes-bsp/rkbin/rk3308-rkbin_git.bb | 2 --
> recipes-bsp/rkbin/rockchip-rkbin-native_git.bb | 2 +-
> recipes-bsp/rkbin/rockchip-rkbin.inc | 2 --
> 3 files changed, 1 insertion(+), 5 deletions(-)
> ---
> base-commit: 961768ccd13630a4b98701f5821372a9ede86e85
> change-id: 20250625-s-unpackdir-8fee740998d0
Applied to meta-rockchip, master branch. Thanks!
prev parent reply other threads:[~2025-06-25 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 12:07 [meta-rockchip PATCH 0/2] bsp: rkbin: fix build issues around S and WORKDIR Quentin Schulz
2025-06-25 12:07 ` [meta-rockchip PATCH 1/2] bsp: rkbin: fix build since S = "${WORKDIR}/git" is implied by OE-Core Quentin Schulz
2025-06-25 12:07 ` [meta-rockchip PATCH 2/2] bsp: rkbin-native: fix build since ${WORKDIR} isn't allowed in S anymore Quentin Schulz
2025-06-25 15:53 ` Trevor Woerner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250625155314.GA14662@localhost \
--to=twoerner@gmail.com \
--cc=quentin.schulz@cherry.de \
--cc=yocto-patches@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.