From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53ECCC7EE2A for ; Wed, 25 Jun 2025 16:12:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2828041D61; Wed, 25 Jun 2025 16:12:20 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 20PntjxyFmp5; Wed, 25 Jun 2025 16:12:19 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 954A641EAB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1750867939; bh=ZSKrbExAoGwvgE3h5wZvMDKnEiBJEg6qC3SK4TyWodQ=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=TTGwHpquO2tb/FskOmMBEd/VOtPcigXlWuscFGM8jIUSbm+ixXjJQFPw+MfST2nNr q55qqtiO9v2mbaKPw9ssM6f3l337ovBgUyyN7oQ01YYuMAOJqYibsP3LrfYRUAB9vG Q+r9ak/9BqsemdVOLDuOG/HIQpigA3kBI5BfyGJ5b4yF+hfAEwXyjUtXvFLWPqCSCd QAiKcH+XbUfGB74h4uJGzqRfX23hcKMf6LA0pkBvLqoiABxN2dYxd3Jn4qFOBf5obg D24MvCt2AKYUKXKF3ED8szTswzChQzYjGmalhHbXFmG/z8hgEeW/LJHUwVib+RaNkx FA2ufjAO9vnJw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 954A641EAB; Wed, 25 Jun 2025 16:12:19 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id CDDE743F for ; Wed, 25 Jun 2025 16:12:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B504441F12 for ; Wed, 25 Jun 2025 16:12:18 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 8LFfHmzKcjQp for ; Wed, 25 Jun 2025 16:12:18 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::432; helo=mail-wr1-x432.google.com; envelope-from=david.laight.linux@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 089D74187D DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 089D74187D Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by smtp2.osuosl.org (Postfix) with ESMTPS id 089D74187D for ; Wed, 25 Jun 2025 16:12:17 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3a6d77b43c9so4088482f8f.3 for ; Wed, 25 Jun 2025 09:12:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750867936; x=1751472736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZSKrbExAoGwvgE3h5wZvMDKnEiBJEg6qC3SK4TyWodQ=; b=qS90iAJp7u+dYJcgg6s+dK5Q/An+/oHFFoGV3518T0mVhxXajiwSyhtZ7Iv477ZhKF bcAPgFZxZmAXb/PSyVOgs8j/DJgqX+xh9FdYHI2MsXQPXb9u80KhAMhGJSurZA75tUKw foEiyavukU5zqnHv61TfuJNKjnwq3fphLylm1l4vJQxP8QAsbZolFXipsMcr3P7LdyQU NoK0Z+/SaSq221I6bvdZv2FGMfvKwDqYXAIBmsqzg21EhYSeNmpaqiDfses4WFPfyk1f te/yoPUgYnO4PKhcyzz3o8zA1chFMjVZsMryKonzn/o0TGeKKOgyXNb/++mBLCoHv3L0 c51Q== X-Forwarded-Encrypted: i=1; AJvYcCU0W2pX/AN4ZbaRcMWLQcEy7K4TqPNOBROX/QtaavJcM8itBTJ90Po87vPou92lYSB63yvHWJlsKMZEnYZBz14=@lists.osuosl.org X-Gm-Message-State: AOJu0YwENXnX/VS+ZtLfPAI501lhkYaBRlTWYk8e+4vPq63OHT38pEEw 21FQfNH1qWS8sFiYpTCdmbo1fKrv14nA+cGz1mSKhZTwDmFa6Cu+t/rb X-Gm-Gg: ASbGncuq2CbdzVEEIUCH8NFResiiY/hPaPvgOrwyYeQZTJ/PKSf8Kcm1e5OsbDuJ7q/ JjgAFHvVcfP9KfgKWUspcNI7IAihjGtiVvCo23rXjIBLJecXPc4KNddcAUT8Lyfb2DNP6fDa3EQ VIavEkpWK11oZ9bMdE6A9mnJNuagIVUJpIczxkPfuFkSisZBWyOsQzLLsnPFsJw8hXnTUTJqYEH LJrWHpZtyhgQNS8tWhjQo6aEI0LUL/KCkacrQNJS33c6YZElhIpPzh4ebPoIXVE97/RFxHQc5ic 8YAd7w6BHczEZPePX8KfIamLC681S2NKkbVtGIYKq1hDkiDeA9r1bSGeNwSM3RrQl2yoStpvCAF hUBav3r8zh4Fm+Km66YDkJ2Pe X-Google-Smtp-Source: AGHT+IH4lJNGPB4RyhVXajT2id0Stq+E++QsUs8QRfnl4dQOmic7Xc9jN2I06E6CUU2T/tXSzcE8NQ== X-Received: by 2002:a5d:5f91:0:b0:3a5:2465:c0a4 with SMTP id ffacd0b85a97d-3a6ed5db111mr2968525f8f.20.1750867935704; Wed, 25 Jun 2025 09:12:15 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6e8114774sm5071397f8f.94.2025.06.25.09.12.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 09:12:15 -0700 (PDT) Date: Wed, 25 Jun 2025 17:12:14 +0100 From: David Laight To: Simon Horman Cc: Jacek Kowalski , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20250625171214.5d752668@pumpkin> In-Reply-To: <20250625122239.GE1562@horms.kernel.org> References: <46b2b70d-bf53-4b0a-a9f3-dfd8493295b9@jacekk.info> <5589e73f-2f18-4c08-8d10-0498555dd6be@jacekk.info> <20250625122239.GE1562@horms.kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750867936; x=1751472736; darn=lists.osuosl.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ZSKrbExAoGwvgE3h5wZvMDKnEiBJEg6qC3SK4TyWodQ=; b=GcEw5XGfAt/haClT4NO5G+p/4mahBoBXqroWMiriN6+nckatmSrXaAd6jULdCkGIhQ hH+apAmoujY3yuKkAzvfukbfeYgMZEQHLYEentexldBx1vGZPPzP7QT8Gu5OdA7S23S0 jYlRD48CZkpaazFoAvYdztt36se8nxlsfNZNMJTaXKtBBvDUte7zHn9dr2RnVm/s5GI1 QaeSIU5XnIAO2qWbSvhUqj5Q+oCeX7DUJBd4Dmi8tPe5uP4h42Ed9vaWap+yI7YiwciS px/T8HV4OkstHZMTDqz1nSqerRmvBi8OBEJiyTaorbGyRQpiFADrZ5YhJEfGgGto3nz2 itAg== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=gmail.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=GcEw5XGf Subject: Re: [Intel-wired-lan] [PATCH 4/4] igc: drop checksum constant cast to u16 in comparisons X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, 25 Jun 2025 13:22:39 +0100 Simon Horman wrote: > On Tue, Jun 24, 2025 at 09:31:08PM +0200, Jacek Kowalski wrote: > > Signed-off-by: Jacek Kowalski > > Suggested-by: Simon Horman > > --- > > drivers/net/ethernet/intel/igc/igc_nvm.c | 2 +- > > I think we should add this: > > diff --git a/drivers/net/ethernet/intel/igc/igc_nvm.c b/drivers/net/ethernet/intel/igc/igc_nvm.c > index c4fb35071636..a47b8d39238c 100644 > --- a/drivers/net/ethernet/intel/igc/igc_nvm.c > +++ b/drivers/net/ethernet/intel/igc/igc_nvm.c > @@ -155,7 +155,7 @@ s32 igc_update_nvm_checksum(struct igc_hw *hw) > } > checksum += nvm_data; > } > - checksum = (u16)NVM_SUM - checksum; > + checksum = NVM_SUM - checksum; Indeed - especially as the '-' code is really: checksum = (int)(u16)NVM_SUM - checksum; David > ret_val = hw->nvm.ops.write(hw, NVM_CHECKSUM_REG, 1, &checksum); > if (ret_val) > hw_dbg("NVM Write Error while updating checksum.\n"); > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBBC917A318; Wed, 25 Jun 2025 16:12:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750867940; cv=none; b=OGFy+ysKLwFWI4xu5uVFya89xM/Xw9wLSOkbQaUQDmLWu89bzntwpHcqnBp27pbReinnWzeYitccLSZQK3RrvJGuA/KFtqHXnbVNG/R827hxIKAfao8v9ARtewNchwmKFR40WYTueTHApxdQcX0pwWWMRUvzBDlv1O0FsT1YVDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750867940; c=relaxed/simple; bh=yG3+snXxvnjzdEUf5t52YKU1CQdD0bOMeG6Sa8cZzPI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KfyIW55M+tAnk6Ue/mmLRQUnMMv77RUY5xFxbsN6h2qvz7/CGeEW9KB/NrUFe9xH731KrEWgg6ZXqLqdGKLfQ80rW+k69jNhRE3k4+FbSxK5Y8otS49Y/9Id5tFEsp7QaquWadrAHysHyMxE5XG3nYYroBmpG6+M18fwneni+zI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b4YwGQ1X; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b4YwGQ1X" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3a507e88b0aso5700241f8f.1; Wed, 25 Jun 2025 09:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750867936; x=1751472736; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ZSKrbExAoGwvgE3h5wZvMDKnEiBJEg6qC3SK4TyWodQ=; b=b4YwGQ1XTbZtbGBLhhbjqfpTr6lEsuhBSz8ItYLdHEjDEYt6nK5LMI4Wj23Ud4EXu/ LUDSghdDk1clZ+xPojJVdXRnJ0tTfWWeOOYSqBGSMM+ryNy9T9atB5SO17lVbKyg8Jzw dxIH0XAHKZIr25kiRdDkaJ0NuTlkDZq2C7GagtrKItkO1F8Ak8mZAkyqVx/eEdwUfl69 FgVEiiOZRA1cn1Xy5Pyh/wlXd1DoWfI6/J5AzcxsKciFFAP4yQcJWm+d8S1sWFQoB8Hc i0cEY6V+JeQ1LQkTE0cMfcMCkCIfrzV9tMUTzu8LTpl/B50PGRbFdrdgiqI42GHw3yx2 9fDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750867936; x=1751472736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZSKrbExAoGwvgE3h5wZvMDKnEiBJEg6qC3SK4TyWodQ=; b=I0ZRz+e5NWxn7HqS0r1TR9Wu5D6lzezutWz5SOFfNC0dFVn39UtFi97f+AvrfmiFf9 +7z4JFxEm0ILOXIj/NEq1pFHDPsIZBI04b4JtjIAVY/SbvKrjm67Ydk7Lv84U9GVyWik OJsC7dYvPb0F5yjQ0bF/D40uShL3HBAv7V0ZEPzuIH13NSN3lYWMhUmFxsF5yZVQCii6 ZTXmsXdzCu/RQ5m4k6AtOewG+HzAbNy/piLOf9YU1gG9gE1EtJd6rl4U1eZyGYy2tyO3 sAm1ycjwpI8tHB8Vts3ylFJDWDPdBh8Ne+409Fj1QFRML7X4M8dDDjv51ZDubT/Be3my E4cg== X-Forwarded-Encrypted: i=1; AJvYcCUh2DsYgyYFMoTlPSWzvUxlVS2gOheoVubGCJl+IRfPX8U9eEwCTCYxPq4fxYPZ+ODaNhJ9CMWs@vger.kernel.org, AJvYcCWt33/bnUi+QiRMEXISFCwI+WG3quKdEDhVSZL+4Jfzc/g0hTbIxA3TmIANOhQOzq4yJLhvGhBZe7SAjeE=@vger.kernel.org X-Gm-Message-State: AOJu0YwRzkAg99Wln3zxF9xu3K+SGFtFM0EaobPmqZ3ZJxRNtQzPTR0+ Tgb70HB7sx5t4S/CwFplpgEqeNydtMoYvfBuptJHKCqos2BM9wKikEXo X-Gm-Gg: ASbGncv2138ISWs0oKn5fP9OVGd4zrfDuTSdJLatujUqLmLIe0pDZ0itKoUDRLd4CRv hf4hX5UG60J//xMF26U1G6U0x95Vsj/2nNNcnFbQDpm82XN7mc58Urdm3KL8cOnq5n944Tve1Lr k3hoGzg43BJa2v2iDT60p9vOKqZ/3+l/Di/w3m1jsAExevEtJNQIcnoH9/A4EW1ijYMWicOHlP0 S25Nu/ELHHA83Iz0BUz6lVVgadOZb0O0CS4rDChp5D453iOuhSXrI1JinKO23y2ai+O8UiXI3Tb R2zgiXyK9YX/4RCi7qCN1W7FwrrhXtkNePtTHlA+x8Ukf0r0iuyJnoHmWXN7NIy65Cxdjx53YlH jPoqwoUvOp1vguncyJyMa6yOO X-Google-Smtp-Source: AGHT+IH4lJNGPB4RyhVXajT2id0Stq+E++QsUs8QRfnl4dQOmic7Xc9jN2I06E6CUU2T/tXSzcE8NQ== X-Received: by 2002:a5d:5f91:0:b0:3a5:2465:c0a4 with SMTP id ffacd0b85a97d-3a6ed5db111mr2968525f8f.20.1750867935704; Wed, 25 Jun 2025 09:12:15 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6e8114774sm5071397f8f.94.2025.06.25.09.12.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 09:12:15 -0700 (PDT) Date: Wed, 25 Jun 2025 17:12:14 +0100 From: David Laight To: Simon Horman Cc: Jacek Kowalski , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] igc: drop checksum constant cast to u16 in comparisons Message-ID: <20250625171214.5d752668@pumpkin> In-Reply-To: <20250625122239.GE1562@horms.kernel.org> References: <46b2b70d-bf53-4b0a-a9f3-dfd8493295b9@jacekk.info> <5589e73f-2f18-4c08-8d10-0498555dd6be@jacekk.info> <20250625122239.GE1562@horms.kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 25 Jun 2025 13:22:39 +0100 Simon Horman wrote: > On Tue, Jun 24, 2025 at 09:31:08PM +0200, Jacek Kowalski wrote: > > Signed-off-by: Jacek Kowalski > > Suggested-by: Simon Horman > > --- > > drivers/net/ethernet/intel/igc/igc_nvm.c | 2 +- > > I think we should add this: > > diff --git a/drivers/net/ethernet/intel/igc/igc_nvm.c b/drivers/net/ethernet/intel/igc/igc_nvm.c > index c4fb35071636..a47b8d39238c 100644 > --- a/drivers/net/ethernet/intel/igc/igc_nvm.c > +++ b/drivers/net/ethernet/intel/igc/igc_nvm.c > @@ -155,7 +155,7 @@ s32 igc_update_nvm_checksum(struct igc_hw *hw) > } > checksum += nvm_data; > } > - checksum = (u16)NVM_SUM - checksum; > + checksum = NVM_SUM - checksum; Indeed - especially as the '-' code is really: checksum = (int)(u16)NVM_SUM - checksum; David > ret_val = hw->nvm.ops.write(hw, NVM_CHECKSUM_REG, 1, &checksum); > if (ret_val) > hw_dbg("NVM Write Error while updating checksum.\n"); >