From: Rob Herring <robh@kernel.org>
To: Chintan Vankar <c-vankar@ti.com>
Cc: Thorsten Blum <thorsten.blum@linux.dev>,
Andrew Davis <afd@ti.com>, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Peter Rosin <peda@axentia.se>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
s-vadapalli@ti.com, vigneshr@ti.com, nm@ti.com,
danishanwar@ti.com
Subject: Re: [PATCH 1/2] devicetree: bindings: mux: reg-mux: Add support for new property 'mux-reg-masks-state'
Date: Wed, 25 Jun 2025 13:48:58 -0500 [thread overview]
Message-ID: <20250625184858.GA2004209-robh@kernel.org> (raw)
In-Reply-To: <20250605063422.3813260-2-c-vankar@ti.com>
On Thu, Jun 05, 2025 at 12:04:21PM +0530, Chintan Vankar wrote:
> The DT binding for reg-mux currenly requires specifying register offset
> and masks in the "mux-reg-masks" property, while corresponding register
> values are defined in the "idle-states" property. This approach imposes a
> constraint where "mux-reg-masks" and "idle-states" must remain
> synchroniszed, adding complexity when configuring specific registers or a
> set of registers with large memory spaces.
Sorry, but I don't follow why there's complexity. Having to support 2
different ways to express the same thing adds complexity we have to
maintain forever. I prefer to impose the complexity on the .dts than
maintainers.
Rob
next prev parent reply other threads:[~2025-06-25 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 6:34 [PATCH 0/2] Add support for new property 'mux-reg-masks-state' for mmio mux Chintan Vankar
2025-06-05 6:34 ` [PATCH 1/2] devicetree: bindings: mux: reg-mux: Add support for new property 'mux-reg-masks-state' Chintan Vankar
2025-06-05 6:46 ` Krzysztof Kozlowski
2025-06-25 18:48 ` Rob Herring [this message]
2025-06-05 6:34 ` [PATCH 2/2] mux: mmio: Extend mmio-mux driver to configure mux with mux-reg-masks-state Chintan Vankar
2025-06-05 6:36 ` Krzysztof Kozlowski
2025-06-05 6:41 ` Chintan Vankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250625184858.GA2004209-robh@kernel.org \
--to=robh@kernel.org \
--cc=afd@ti.com \
--cc=c-vankar@ti.com \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=peda@axentia.se \
--cc=s-vadapalli@ti.com \
--cc=thorsten.blum@linux.dev \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.