From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,vbabka@suse.cz,osalvador@suse.de,Jonathan.Cameron@huawei.com,david@redhat.com,dan.carpenter@linaro.org,akpm@linux-foundation.org
Subject: + mmmemory_hotplug-implement-numa-node-notifier-fix.patch added to mm-unstable branch
Date: Wed, 25 Jun 2025 13:28:58 -0700 [thread overview]
Message-ID: <20250625202858.D4F8DC4CEEA@smtp.kernel.org> (raw)
The patch titled
Subject: mm,memory_hotplug: set failure reason in offline_pages()
has been added to the -mm mm-unstable branch. Its filename is
mmmemory_hotplug-implement-numa-node-notifier-fix.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mmmemory_hotplug-implement-numa-node-notifier-fix.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Dan Carpenter <dan.carpenter@linaro.org>
Subject: mm,memory_hotplug: set failure reason in offline_pages()
Date: Wed, 25 Jun 2025 10:32:04 -0500
The "reason" variable is uninitialized on this error path. It's supposed
to explain why the function failed.
Link: https://lkml.kernel.org/r/be4fd31b-7d09-46b0-8329-6d0464ffa7a5@sabinyo.mountain
Fixes: e4e2806b639c ("mm,memory_hotplug: implement numa node notifier")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: David Hildenbrand <david@redhat.com>
Acked-by: Oscar Salvador <osalvador@suse.de>
Cc: Joanthan Cameron <Jonathan.Cameron@huawei.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/memory_hotplug.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/mm/memory_hotplug.c~mmmemory_hotplug-implement-numa-node-notifier-fix
+++ a/mm/memory_hotplug.c
@@ -1978,8 +1978,10 @@ int offline_pages(unsigned long start_pf
mem_arg.status_change_nid = node;
ret = node_notify(NODE_REMOVING_LAST_MEMORY, &node_arg);
ret = notifier_to_errno(ret);
- if (ret)
+ if (ret) {
+ reason = "node notifier failure";
goto failed_removal_isolated;
+ }
}
ret = memory_notify(MEM_GOING_OFFLINE, &mem_arg);
_
Patches currently in -mm which might be from dan.carpenter@linaro.org are
mmmemory_hotplug-implement-numa-node-notifier-fix.patch
reply other threads:[~2025-06-25 20:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250625202858.D4F8DC4CEEA@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=dan.carpenter@linaro.org \
--cc=david@redhat.com \
--cc=mm-commits@vger.kernel.org \
--cc=osalvador@suse.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.