From: Simon Horman <horms@kernel.org>
To: Subbaraya Sundeep <sbhatta@marvell.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, sgoutham@marvell.com,
gakula@marvell.com, hkelam@marvell.com, bbhushan2@marvell.com,
netdev@vger.kernel.org, Suman Ghosh <sumang@marvell.com>
Subject: Re: [net-next PATCH] octeontx2-pf: Check for DMAC extraction before setting VF DMAC
Date: Thu, 26 Jun 2025 08:25:05 +0100 [thread overview]
Message-ID: <20250626072505.GR1562@horms.kernel.org> (raw)
In-Reply-To: <aFznYtDq9ywfk5FJ@822c91e11a5c>
On Thu, Jun 26, 2025 at 06:23:30AM +0000, Subbaraya Sundeep wrote:
> On 2025-06-25 at 19:02:47, Simon Horman (horms@kernel.org) wrote:
> > On Wed, Jun 25, 2025 at 05:00:02PM +0530, Subbaraya Sundeep wrote:
> > > From: Suman Ghosh <sumang@marvell.com>
> > >
> > > Currently while setting a MAC address of a PF's VF (e.g. ip link set
> > > <pf-netdev> vf 0 mac <mac-address>), it simply tries to install a DMAC
> > > based hardware filter. But it is possible that the loaded hardware parser
> > > profile does not support DMAC extraction. Hence check for DMAC extraction
> > > before installing the filter.
> >
> > Makes sense to me, but should this be treated as a bug fix?
> >
> No strong opinion on whether this is a bug fix or not.
> We assumed DMAC is required always until on of our customers
> came up with profile with no DMAC extraction so that they can
> use the additional MCAM space created for other packet fields.
> I will send as bug fix if you insist.
No strong feeling on my side either.
Let's leave it for net-next unless someone else thinks otherwise.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-06-26 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 11:30 [net-next PATCH] octeontx2-pf: Check for DMAC extraction before setting VF DMAC Subbaraya Sundeep
2025-06-25 19:02 ` Simon Horman
2025-06-26 6:23 ` Subbaraya Sundeep
2025-06-26 7:25 ` Simon Horman [this message]
2025-06-27 23:59 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250626072505.GR1562@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.