From: Simon Horman <horms@kernel.org>
To: Fushuai Wang <wangfushuai@baidu.com>
Cc: saeedm@nvidia.com, tariqt@nvidia.com, leon@kernel.org,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhu Yanjun <yanjun.zhu@linux.dev>,
Dragos Tatulea <dtatulea@nvidia.com>
Subject: Re: [PATCH net-next v2] net/mlx5e: Fix error handling in RQ memory model registration
Date: Thu, 26 Jun 2025 10:07:53 +0100 [thread overview]
Message-ID: <20250626090753.GU1562@horms.kernel.org> (raw)
In-Reply-To: <20250626053003.45807-1-wangfushuai@baidu.com>
On Thu, Jun 26, 2025 at 01:30:03PM +0800, Fushuai Wang wrote:
> Currently when xdp_rxq_info_reg_mem_model() fails in the XSK path, the
> error handling incorrectly jumps to err_destroy_page_pool. While this
> may not cause errors, we should make it jump to the correct location.
>
> Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
> Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> Acked-by: Dragos Tatulea <dtatulea@nvidia.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Thanks for rebasing.
This version applies cleanly and otherwise LGTM.
next prev parent reply other threads:[~2025-06-26 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 5:30 [PATCH net-next v2] net/mlx5e: Fix error handling in RQ memory model registration Fushuai Wang
2025-06-26 9:07 ` Simon Horman [this message]
2025-06-30 9:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250626090753.GU1562@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=wangfushuai@baidu.com \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.