From: Jakub Kicinski <kuba@kernel.org>
To: Mark Bloch <mbloch@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
Simon Horman <horms@kernel.org>, <saeedm@nvidia.com>,
<gal@nvidia.com>, <leonro@nvidia.com>, <tariqt@nvidia.com>,
Donald Hunter <donald.hunter@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Jonathan Corbet <corbet@lwn.net>,
Leon Romanovsky <leon@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Shuah Khan <shuah@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <linux-nfs@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>,
Carolina Jubran <cjubran@nvidia.com>,
Cosmin Ratiu <cratiu@nvidia.com>, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next v11 2/8] devlink: Extend devlink rate API with traffic classes bandwidth management
Date: Thu, 26 Jun 2025 18:01:02 -0700 [thread overview]
Message-ID: <20250626180102.497e35a2@kernel.org> (raw)
In-Reply-To: <20250625183018.87065-3-mbloch@nvidia.com>
On Wed, 25 Jun 2025 21:30:12 +0300 Mark Bloch wrote:
> Introduce support for specifying relative bandwidth shares between
> traffic classes (TC) in the devlink-rate API. This new option allows
> users to allocate bandwidth across multiple traffic classes in a
> single command.
net/devlink/rate.c:390:33: warning: variable 'total' set but not used [-Wunused-but-set-variable]
390 | int rem, err = -EOPNOTSUPP, i, total = 0;
| ^
Documentation/netlink/specs/devlink.yaml
1277:8 error wrong indentation: expected 8 but found 7 (indentation)
1279:8 error wrong indentation: expected 8 but found 7 (indentation)
--
pw-bot: cr
next prev parent reply other threads:[~2025-06-27 1:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 18:30 [PATCH net-next v11 0/8] Support rate management on traffic classes in devlink and mlx5 Mark Bloch
2025-06-25 18:30 ` [PATCH net-next v11 1/8] netlink: introduce type-checking attribute iteration for nlmsg Mark Bloch
2025-06-25 18:30 ` [PATCH net-next v11 2/8] devlink: Extend devlink rate API with traffic classes bandwidth management Mark Bloch
2025-06-27 1:01 ` Jakub Kicinski [this message]
2025-06-25 18:30 ` [PATCH net-next v11 3/8] selftest: netdevsim: Add devlink rate tc-bw test Mark Bloch
2025-06-25 18:30 ` [PATCH net-next v11 4/8] net/mlx5: Add no-op implementation for setting tc-bw on rate objects Mark Bloch
2025-06-25 18:30 ` [PATCH net-next v11 5/8] net/mlx5: Add support for setting tc-bw on nodes Mark Bloch
2025-06-25 18:30 ` [PATCH net-next v11 6/8] net/mlx5: Add traffic class scheduling support for vport QoS Mark Bloch
2025-06-25 18:30 ` [PATCH net-next v11 7/8] net/mlx5: Manage TC arbiter nodes and implement full support for tc-bw Mark Bloch
2025-06-25 18:30 ` [PATCH net-next v11 8/8] selftests: drv-net: Add test for devlink-rate traffic class bandwidth distribution Mark Bloch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250626180102.497e35a2@kernel.org \
--to=kuba@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=chuck.lever@oracle.com \
--cc=cjubran@nvidia.com \
--cc=corbet@lwn.net \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=jlayton@kernel.org \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=neil@brown.name \
--cc=netdev@vger.kernel.org \
--cc=okorniev@redhat.com \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.