From: "Frédéric Danis" <frederic.danis@collabora.com>
To: linux-bluetooth@vger.kernel.org
Subject: [RFC BlueZ v2 24/27] audio/hfp-hf: Enable waiting call if supported by remote AG
Date: Fri, 27 Jun 2025 16:51:33 +0200 [thread overview]
Message-ID: <20250627145136.421853-25-frederic.danis@collabora.com> (raw)
In-Reply-To: <20250627145136.421853-1-frederic.danis@collabora.com>
---
profiles/audio/hfp-hf.c | 71 +++++++++++++++++++++++++++++++++++++++--
1 file changed, 69 insertions(+), 2 deletions(-)
diff --git a/profiles/audio/hfp-hf.c b/profiles/audio/hfp-hf.c
index 5e3c9fcba..afe06296d 100644
--- a/profiles/audio/hfp-hf.c
+++ b/profiles/audio/hfp-hf.c
@@ -107,6 +107,9 @@
HFP_HF_FEAT_ENHANCED_CALL_STATUS |\
HFP_HF_FEAT_ESCO_S4_T2)
+#define CHLD_3WAY_FEATURES (CHLD_FEAT_REL | CHLD_FEAT_REL_ACC |\
+ CHLD_FEAT_HOLD_ACC | CHLD_FEAT_MERGE)
+
#define MAX_NUMBER_LEN 33
#define MAX_OPERATOR_NAME_LEN 17
@@ -331,6 +334,46 @@ static uint8_t next_index(struct hfp_device *dev)
return 0;
}
+static void ccwa_cb(struct hfp_context *context, void *user_data)
+{
+ struct hfp_device *dev = user_data;
+ char number[MAX_NUMBER_LEN];
+ GSList *l;
+ bool found = false;
+
+ DBG("");
+
+ if (!hfp_context_get_string(context, number, MAX_NUMBER_LEN)) {
+ error("hf-client: incorrect +CCWA event");
+ return;
+ }
+
+ for (l = dev->calls; l; l = l->next) {
+ struct call *call = l->data;
+
+ if (call->state == CALL_STATE_WAITING) {
+ info("hf-client: waiting call in progress (id: %d)",
+ call->idx);
+ found = true;
+ break;
+ }
+ }
+
+ if (!found) {
+ struct call *call;
+ uint8_t idx = next_index(dev);
+
+ call = telephony_new_call(dev->telephony, idx,
+ CALL_STATE_WAITING, NULL);
+ call->line_id = g_strdup(number);
+ if (telephony_call_register_interface(call)) {
+ telephony_free_call(call);
+ return;
+ }
+ dev->calls = g_slist_append(dev->calls, call);
+ }
+}
+
static void ciev_cb(struct hfp_context *context, void *user_data)
{
struct hfp_device *dev = user_data;
@@ -407,6 +450,25 @@ static void cops_cb(struct hfp_context *context, void *user_data)
telephony_set_operator_name(dev->telephony, name);
}
+static void nrec_resp(enum hfp_result result, enum hfp_error cme_err,
+ void *user_data)
+{
+ struct hfp_device *dev = user_data;
+
+ DBG("");
+
+ if (result != HFP_RESULT_OK) {
+ error("hf-client: CLIP error: %d", result);
+ return;
+ }
+
+ if ((dev->chld_features & CHLD_3WAY_FEATURES) == CHLD_3WAY_FEATURES) {
+ if (!hfp_hf_send_command(dev->hf, cmd_complete_cb, dev,
+ "AT+CCWA=1"))
+ info("hf-client: Could not send AT+CCWA=1");
+ }
+}
+
static void clip_resp(enum hfp_result result, enum hfp_error cme_err,
void *user_data)
{
@@ -421,9 +483,13 @@ static void clip_resp(enum hfp_result result, enum hfp_error cme_err,
if ((dev->hfp_hf_features & HFP_HF_FEAT_ECNR) &&
(dev->features & HFP_AG_FEAT_ECNR)) {
- if (!hfp_hf_send_command(dev->hf, cmd_complete_cb, dev,
- "AT+NREC=0"))
+ if (!hfp_hf_send_command(dev->hf, nrec_resp, dev, "AT+NREC=0"))
info("hf-client: Could not send AT+NREC=0");
+ } else if ((dev->chld_features & CHLD_3WAY_FEATURES) ==
+ CHLD_3WAY_FEATURES) {
+ if (!hfp_hf_send_command(dev->hf, cmd_complete_cb, dev,
+ "AT+CCWA=1"))
+ info("hf-client: Could not send AT+CCWA=1");
}
}
@@ -480,6 +546,7 @@ static void slc_completed(struct hfp_device *dev)
/* TODO: register unsolicited results handlers */
+ hfp_hf_register(dev->hf, ccwa_cb, "+CCWA", dev, NULL);
hfp_hf_register(dev->hf, ciev_cb, "+CIEV", dev, NULL);
hfp_hf_register(dev->hf, clip_cb, "+CLIP", dev, NULL);
hfp_hf_register(dev->hf, cops_cb, "+COPS", dev, NULL);
--
2.43.0
next prev parent reply other threads:[~2025-06-27 14:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 14:51 [RFC BlueZ v2 00/27] New Telephony interface for HSP, HFP and CCP Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 01/27] doc: Add new telephony related profiles interfaces Frédéric Danis
2025-06-27 16:15 ` New Telephony interface for HSP, HFP and CCP bluez.test.bot
2025-07-02 17:38 ` [RFC BlueZ v2 01/27] doc: Add new telephony related profiles interfaces Luiz Augusto von Dentz
2025-06-27 14:51 ` [RFC BlueZ v2 02/27] audio/telephony: Add shared interfaces implementation Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 03/27] audio/telephony: Add skeleton for HFP profile Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 04/27] audio/hfp-hf: Add HFP SLC connection and event support Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 05/27] audio/hfp-hf: Add dial support Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 06/27] audio/hfp-hf: Add hangup all calls support Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 07/27] audio/hfp-hf: Add answer a specific call support Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 08/27] client/telephony: Add new submenu Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 09/27] audio/hfp-hf: Remove call interface during profile disconnection Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 10/27] audio/hfp-hf: Create existing call during SLC phase Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 11/27] audio/telephony: Add hangup_active and hangup_held functions Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 12/27] audio/hfp-hf: Add hangup_active and hangup_held support Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 13/27] client/telephony: " Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 14/27] audio/hfp-hf: Add SendTones support Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 15/27] client/telephony: " Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 16/27] doc: Make telephony docs more generic Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 17/27] client/telephony: Remove IncomingLine Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 18/27] audio/telephony: " Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 19/27] audio/hfp-hf: Add HFP HF server and SDP record Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 20/27] audio/hfp-hf: Add operator name support Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 21/27] audio/telephony: Add call line identication property support Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 22/27] audio/hfp-hf: Add call line idenfication support Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 23/27] audio/hfp-hf: Disable NREC during connection setup Frédéric Danis
2025-06-27 14:51 ` Frédéric Danis [this message]
2025-06-27 14:51 ` [RFC BlueZ v2 25/27] audio/hfp-hf: Enable extended error if supported by remote AG Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 26/27] audio/telephony: Add call multiparty property support Frédéric Danis
2025-06-27 14:51 ` [RFC BlueZ v2 27/27] audio/hfp-hf: Enable enhanced call status if supported by remote AG Frédéric Danis
2025-07-02 17:50 ` [RFC BlueZ v2 00/27] New Telephony interface for HSP, HFP and CCP Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250627145136.421853-25-frederic.danis@collabora.com \
--to=frederic.danis@collabora.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.