Re: [linux-next:master 5320/5590] mm/damon/sysfs-schemes.c:1622:32: sparse: sparse: symbol 'damos_sysfs_action_names' was not declared. Should it be static?

[SeongJae Park <sj@kernel.org>]

On Fri, 27 Jun 2025 12:57:31 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:

> On Fri, 27 Jun 2025 16:41:02 +0800 kernel test robot <lkp@intel.com> wrote:
[...]
> > sparse warnings: (new ones prefixed by >>)
> > >> mm/damon/sysfs-schemes.c:1622:32: sparse: sparse: symbol 'damos_sysfs_action_names' was not declared. Should it be static?
> 
> Thanks.
> 
> --- a/mm/damon/sysfs-schemes.c~mm-damon-sysfs-schemes-decouple-from-damos_action-fix
> +++ a/mm/damon/sysfs-schemes.c
> @@ -1619,7 +1619,7 @@ struct damos_sysfs_action_name {
>  	char *name;
>  };
>  
> -struct damos_sysfs_action_name damos_sysfs_action_names[] = {
> +static struct damos_sysfs_action_name damos_sysfs_action_names[] = {
>  	{
>  		.action = DAMOS_WILLNEED,
>  		.name = "willneed",
> _

Thank you Andrew.  I posted a same fix[1] but forgot noting that here.  Since
it is same to yours and yours is already added to mm tree, let's keep using
yours unless you mind.

FWIW,

Reviewed-by: SeongJae Park <sj@kernel.org>

[1] https://lore.kernel.org/20250627162806.50589-1-sj@kernel.org


Thanks,
SJ