All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: cros-kernel-buildreports@googlegroups.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [android-common:android16-6.12-desktop 0/2] drivers/usb/host/xhci-sideband.c:263: warning: Function parameter or struct member 'intr_num' not described in 'xhci_sideband_create_interrupter'
Date: Fri, 27 Jun 2025 14:40:36 +0200	[thread overview]
Message-ID: <202506272012.w0aBh5XW-lkp@intel.com> (raw)

tree:   https://android.googlesource.com/kernel/common android16-6.12-desktop
head:   0144e2490a70c3551bfb173921278f21d8255d44
commit: c354230ab97feb64813581d381c9f199ed70dd33 [0/2] FROMGIT: usb: host: xhci-mem: Allow for interrupter clients to choose specific index
config: x86_64-buildonly-randconfig-2001-20250626 (https://download.01.org/0day-ci/archive/20250627/202506272012.w0aBh5XW-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250627/202506272012.w0aBh5XW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506272012.w0aBh5XW-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/usb/host/xhci-sideband.c:263: warning: Function parameter or struct member 'imod_interval' not described in 'xhci_sideband_create_interrupter'
>> drivers/usb/host/xhci-sideband.c:263: warning: Function parameter or struct member 'intr_num' not described in 'xhci_sideband_create_interrupter'
   drivers/usb/host/xhci-sideband.c:346: warning: Function parameter or struct member 'type' not described in 'xhci_sideband_register'


vim +263 drivers/usb/host/xhci-sideband.c

8b9c57ce39a5a8 Mathias Nyman 2025-04-09  244  
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  245  /**
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  246   * xhci_sideband_create_interrupter - creates a new interrupter for this sideband
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  247   * @sb: sideband instance for this usb device
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  248   * @num_seg: number of event ring segments to allocate
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  249   * @ip_autoclear: IP autoclearing support such as MSI implemented
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  250   *
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  251   * Sets up a xhci interrupter that can be used for this sideband accessed usb
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  252   * device. Transfer events for this device can be routed to this interrupters
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  253   * event ring by setting the 'Interrupter Target' field correctly when queueing
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  254   * the transfer TRBs.
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  255   * Once this interrupter is created the interrupter target ID can be obtained
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  256   * by calling xhci_sideband_interrupter_id()
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  257   *
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  258   * Returns 0 on success, negative error otherwise
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  259   */
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  260  int
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  261  xhci_sideband_create_interrupter(struct xhci_sideband *sb, int num_seg,
c354230ab97feb Wesley Cheng  2025-04-09  262  				 bool ip_autoclear, u32 imod_interval, int intr_num)
8b9c57ce39a5a8 Mathias Nyman 2025-04-09 @263  {
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  264  	int ret = 0;
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  265  
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  266  	if (!sb || !sb->xhci)
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  267  		return -ENODEV;
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  268  
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  269  	mutex_lock(&sb->mutex);
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  270  	if (sb->ir) {
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  271  		ret = -EBUSY;
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  272  		goto out;
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  273  	}
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  274  
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  275  	sb->ir = xhci_create_secondary_interrupter(xhci_to_hcd(sb->xhci),
c354230ab97feb Wesley Cheng  2025-04-09  276  						   num_seg, imod_interval,
c354230ab97feb Wesley Cheng  2025-04-09  277  						   intr_num);
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  278  	if (!sb->ir) {
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  279  		ret = -ENOMEM;
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  280  		goto out;
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  281  	}
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  282  
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  283  	sb->ir->ip_autoclear = ip_autoclear;
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  284  
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  285  out:
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  286  	mutex_unlock(&sb->mutex);
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  287  
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  288  	return ret;
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  289  }
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  290  EXPORT_SYMBOL_GPL(xhci_sideband_create_interrupter);
8b9c57ce39a5a8 Mathias Nyman 2025-04-09  291  

:::::: The code at line 263 was first introduced by commit
:::::: 8b9c57ce39a5a88dbc923cebe1fdd234239a7f94 FROMGIT: xhci: sideband: add initial api to register a secondary interrupter entity

:::::: TO: Mathias Nyman <mathias.nyman@linux.intel.com>
:::::: CC: Carlos Llamas <cmllamas@google.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2025-06-27 12:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202506272012.w0aBh5XW-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=cros-kernel-buildreports@googlegroups.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.