From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
James Clark <james.clark@linaro.org>,
Xu Yang <xu.yang_2@nxp.com>,
John Garry <john.g.garry@oracle.com>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Howard Chu <howardchu95@gmail.com>,
Weilin Wang <weilin.wang@intel.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Andi Kleen <ak@linux.intel.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Gautam Menghani <gautam@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: [PATCH v4 02/15] perf parse-events: Minor tidy up of event_type helper
Date: Fri, 27 Jun 2025 17:09:16 -0700 [thread overview]
Message-ID: <20250628000929.230406-3-irogers@google.com> (raw)
In-Reply-To: <20250628000929.230406-1-irogers@google.com>
Add missing breakpoint and raw types. Avoid a switch, just use a
lookup array. Switch the type to unsigned to avoid checking negative
values.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/parse-events.c | 31 +++++++++++++------------------
tools/perf/util/parse-events.h | 2 +-
2 files changed, 14 insertions(+), 19 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 4cd64ffa4fcd..a59ae5ca0f89 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -135,26 +135,21 @@ const struct event_symbol event_symbols_sw[PERF_COUNT_SW_MAX] = {
},
};
-const char *event_type(int type)
-{
- switch (type) {
- case PERF_TYPE_HARDWARE:
- return "hardware";
-
- case PERF_TYPE_SOFTWARE:
- return "software";
-
- case PERF_TYPE_TRACEPOINT:
- return "tracepoint";
-
- case PERF_TYPE_HW_CACHE:
- return "hardware-cache";
+static const char *const event_types[] = {
+ [PERF_TYPE_HARDWARE] = "hardware",
+ [PERF_TYPE_SOFTWARE] = "software",
+ [PERF_TYPE_TRACEPOINT] = "tracepoint",
+ [PERF_TYPE_HW_CACHE] = "hardware-cache",
+ [PERF_TYPE_RAW] = "raw",
+ [PERF_TYPE_BREAKPOINT] = "breakpoint",
+};
- default:
- break;
- }
+const char *event_type(size_t type)
+{
+ if (type >= PERF_TYPE_MAX)
+ return "unknown";
- return "unknown";
+ return event_types[type];
}
static char *get_config_str(const struct parse_events_terms *head_terms,
diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h
index 1c20ed0879aa..b47bf2810112 100644
--- a/tools/perf/util/parse-events.h
+++ b/tools/perf/util/parse-events.h
@@ -21,7 +21,7 @@ struct option;
struct perf_pmu;
struct strbuf;
-const char *event_type(int type);
+const char *event_type(size_t type);
/* Arguments encoded in opt->value. */
struct parse_events_option_args {
--
2.50.0.727.gbf7dc18ff4-goog
next prev parent reply other threads:[~2025-06-28 0:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 0:09 [PATCH v4 00/15] New perf ilist app Ian Rogers
2025-06-28 0:09 ` [PATCH v4 01/15] perf hwmon_pmu: Avoid shortening hwmon PMU name Ian Rogers
2025-06-28 0:09 ` Ian Rogers [this message]
2025-06-28 0:09 ` [PATCH v4 03/15] perf python: In str(evsel) use the evsel__pmu_name helper Ian Rogers
2025-06-28 0:09 ` [PATCH v4 04/15] perf python: Fix thread check in pyrf_evsel__read Ian Rogers
2025-06-28 0:09 ` [PATCH v4 05/15] perf python: Correct pyrf_evsel__read for tool PMUs Ian Rogers
2025-06-28 0:09 ` [PATCH v4 06/15] perf python: Add basic PMU abstraction and pmus sequence Ian Rogers
2025-06-28 0:09 ` [PATCH v4 07/15] perf python: Add function returning dictionary of all events on a PMU Ian Rogers
2025-06-28 0:09 ` [PATCH v4 08/15] perf jevents: If the long_desc and desc are identical then drop the long_desc Ian Rogers
2025-06-28 0:09 ` [PATCH v4 09/15] perf jevents: Add common software event json Ian Rogers
2025-06-28 0:09 ` [PATCH v4 10/15] perf pmu: Tolerate failure to read the type for wellknown PMUs Ian Rogers
2025-06-28 0:09 ` [PATCH v4 11/15] perf parse-events: Remove non-json software events Ian Rogers
2025-06-28 0:09 ` [PATCH v4 12/15] perf tp_pmu: Factor existing tracepoint logic to new file Ian Rogers
2025-06-28 0:09 ` [PATCH v4 13/15] perf tp_pmu: Add event APIs Ian Rogers
2025-06-28 0:09 ` [PATCH v4 14/15] perf list: Remove tracepoint printing code Ian Rogers
2025-06-28 0:09 ` [PATCH v4 15/15] perf ilist: Add new python ilist command Ian Rogers
2025-07-09 16:35 ` [PATCH v4 00/15] New perf ilist app Namhyung Kim
2025-07-09 17:13 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250628000929.230406-3-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=gautam@linux.ibm.com \
--cc=howardchu95@gmail.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
--cc=weilin.wang@intel.com \
--cc=xu.yang_2@nxp.com \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.