From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5C0481DB548 for ; Sun, 29 Jun 2025 09:40:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=163.172.96.212 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751190053; cv=none; b=fgDbEyP7ZpsykCwsAZKkhNbqj4F/Y68FkVmurGpALzlADl8w4JdzlNWPsEKdW1GdqY4jbcsHZTGcwnIIecak18sL6c5+jOsKtyZiOSDgXxRVq19Z8uR+XYE36tS6cWQcxfcIS0Xx8EcF072e8CFzM57lpstC4HMqjbE0+d1VPt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751190053; c=relaxed/simple; bh=x5kWgT89oI1QSxAu9EJcGTcUKttLMgr+HGE0DGqeI8I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Rgbm7C0NPSyHHVLai+Re8QComVcU4LWXf2J6sOvvrmaU5ALcKhfw/KpnqMJyl2uDK9cxXl9laddMpX4e/AynDoegjzrgJSP1ZmDNuB12crYeq+yVo/oEFl0EX62uEtVp9HDUh3x8W+cXfo0G/lIO49lLvQlK7T/Z5xpuM2LYWLw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=1wt.eu; spf=pass smtp.mailfrom=1wt.eu; arc=none smtp.client-ip=163.172.96.212 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=1wt.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1wt.eu Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 55T9emEW022315; Sun, 29 Jun 2025 11:40:48 +0200 Date: Sun, 29 Jun 2025 11:40:48 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] tools/nolibc: move FD_* definitions to sys/select.h Message-ID: <20250629094048.GA26861@1wt.eu> References: <20250620100251.9877-1-w@1wt.eu> <20250620100251.9877-4-w@1wt.eu> <25eb3144-d19e-43d2-af4f-b0251d28808c@t-8ch.de> <20250622071958.GA3384@1wt.eu> <07f5fdb4-2c5c-4723-b12a-abdb0c9f33b7@t-8ch.de> <20250623025618.GA29015@1wt.eu> <20250629084628.GA7992@1wt.eu> <20250629092552.GA30947@1wt.eu> <029f24fa-3512-4736-94a0-e158c158cc8e@t-8ch.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <029f24fa-3512-4736-94a0-e158c158cc8e@t-8ch.de> User-Agent: Mutt/1.10.1 (2018-07-13) On Sun, Jun 29, 2025 at 11:37:06AM +0200, Thomas Weißschuh wrote: > On 2025-06-29 11:25:52+0200, Willy Tarreau wrote: > > On Sun, Jun 29, 2025 at 10:53:34AM +0200, Thomas Weißschuh wrote: > > > On 2025-06-29 10:46:28+0200, Willy Tarreau wrote: > > > > On Mon, Jun 23, 2025 at 04:56:18AM +0200, Willy Tarreau wrote: > > > > > > > Trying it has reopened the circular dependencies can of worms :-( > > > > It's the same problem as usual that we've worked around till now > > > > by placing some types in types.h, except that this time fd_set is > > > > defined based on the macros FD_* that I moved to sys/select.h. > > > > > > Can't fd_set also move to sys/select.h? This is how I read fd_set(3). > > > > That was what I did and precisely what was causing the problem. We > > have sys.h defining select() with fd_set in it with sys/select not yet > > being included. I moved sys.h after all sys/* and it broke something > > else instead. > > Ah. Then move select() also into sys/select.h; where it belongs. :-) For an unknown reason I thought we avoided to move the syscall definitions there and only used sys/*, but I was apparently confused as we have exactly that in prctl or wait. I can give that one a try again. Thanks, Willy