From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1631FC7EE39 for ; Sun, 29 Jun 2025 12:41:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=kUTZn3W2htPA/qP+uxKLCOQdjEPViFtFwYmPnrLX6zA=; b=Y8TeBa1ndr/23/4cVbqzMT3pO5 W5xZ+XZrBUKdle2gJ/pDJtMgCqWACibUiUuysIETdN3oo5A6eDhwqFYU7iQo+tpBYlKZ1w5eMDKSQ C09V4UYMU5XvRWgTimC3WzEdLfXpgMHtsAtDERYSFuPwFf67HcaicKH2+bTIcK4pztNN07z01Y9Qb OeNFSV8Rg0W5VS2cqWBQXI9lkCu2IWRsiB3cJRrStyw1nqZK3k3VwDHKQHK4yCDG51JGTmMkWPiAv r3b51HytZUM5ED2lBCgnoa0h0FMzCrHxytQaPd0w7I5GcWZUwnY/n0Zr8jTNBr7643bC8u/C/2Ozn XByiLpYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uVrLS-00000000E8k-3kGw; Sun, 29 Jun 2025 12:41:18 +0000 Received: from out-171.mta0.migadu.com ([91.218.175.171]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uVrJ7-00000000De0-0cyg for linux-arm-kernel@lists.infradead.org; Sun, 29 Jun 2025 12:38:54 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1751200730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=kUTZn3W2htPA/qP+uxKLCOQdjEPViFtFwYmPnrLX6zA=; b=ux99PPjs/gP+9fYBEUUyJ112v3HpFfuLT0xStBbh43QFM67s7agqYqxUqsPVAcBTwsZU/1 Sd6ssxdDeIMaVdXrnvGPMQhAZP/G59eMB4q/IylHgMkO6F+Z/mR5m+SIDhf0+nWKBhpZuG rYyfEyEDQ5/OvLoQmqfQ8dq6NiORnE7RkQEAwhG+JPTmx72yHJZKoqxl18mOTrO1zDQR2A SZIOpugSEhVmg8U9WJ7VwLuqdnwk6MxiQIhzjT5gJZM8fljbbB9dVnUieDyKUibl6HyZ75 pb2ySMgmEL+/Dopg+vWOac5jK6Jr2dCkg1lFV4uA3Pa32HT6CN6VKJr/j3af7A== From: Diederik de Haas To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Dragan Simic , Quentin Schulz , Johan Jonker , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Diederik de Haas Subject: [PATCH v3 00/10] Fix several DTB validation issues Date: Sun, 29 Jun 2025 14:34:41 +0200 Message-ID: <20250629123840.34948-1-didi.debian@cknow.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250629_053853_590460_1C3AEF89 X-CRM114-Status: GOOD ( 14.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This patch set fixes several DTB validation issues and consists of 2 parts: 1) dsi refactoring 2) various low-hanging fruit ad 1) The display/rockchip/rockchip,dw-mipi-dsi.yaml binding had: - #address-cells - #size-cells My guess is that those properties were added for panel(s) which could be connected. While convenient, it's not a property of the DSI controller (in the SoC). And caused DTB validation issues when a panel was not connected to the board. So add the #address/#size-cells properties to the board dts[i] file where there is a panel and then remove the properties from the SoC dtsi file ... and then from the binding file as well. ad 2) There were a number of issues which were obvious to me how to fix, so I fixed those as well. One of those was the addition of port(s) or endpoints, but for that the context (ie parent nodes) got redefined ... to the same values they had in the SoC dsi node. The SoC dsi node already defined the structure where each port got a label/phandle. That allows for a simplification of the port/endpoint by referencing that label/phandle. My changes were based on yesterday's v6.17-armsoc/dts64 branch: 7f9509791507 ("arm64: dts: rockchip: add DTs for Firefly ROC-RK3588S-PC") Then applied the following patches: 86491c2b99e5 ("dt-bindings: pinctrl: rockchip: increase max amount of device functions") 6f446bbe412a ("dt-bindings: gpu: mali-utgard: Add Rockchip RK3528 compatible") ab9be0b75af5 ("dt-bindings: display: himax-hx8394: Add Huiling hl055fhav028c") 8358102806c6 ("dt-bindings: power: rockchip: Add support for RK3528") 233eda069994 ("dt-bindings: rockchip: pmu: Add compatible for RK3528") And then validated it with W=1 using dtschema-2025.6.1. The validation log file sizes: - base: 99.9 KiB - dsi: 82.2 KiB - low-hanging-fruit: 69.0 KiB I then checked whether dmesg wouldn't indicate problem on these boards: - Rock64 (rk3328) - RockPro64 (rk3399) - PineTab2 (rk3566) And I didn't find any. I don't have any px30 or rk3399-gru-* based boards, so I couldn't test with those. Changes in v2: - Move refactoring of port/endpoint definition to its own patch (Quentin) - Move re-ordering of nodes to its own patch (Quentin) Link to v1: https://lore.kernel.org/linux-rockchip/20250627152645.740981-1-didi.debian@cknow.org/ Changes in v3: - Fix syntax error in RP64 screen dtso (kernel test robot) Link to v2: https://lore.kernel.org/linux-rockchip/20250628144915.839338-1-didi.debian@cknow.org/ I also identified some other items which could reduce the DTB validation 'noise' substantially: "failed to match any schema with compatible" errors: - 'mps,mp8859': regulator/mp8859.txt - 'realtek,rt5651': sound/rt5651.txt - 'rockchip,rk3368-mailbox': mailbox/rockchip-mailbox.txt - 'rockchip,rk3399-gru-sound': sound/rockchip,rk3399-gru-sound.txt - 'ti,tsc2007': input/touchscreen/tsc2007.txt Other issues where a (small?) fix may help a lot: px30: - /isp@ff4a0000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary - /syscon@ff140000/lvds/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary - /dsi@ff450000/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary rk3399: - /usb@fe800000: node has a unit name, but no reg or ranges property - /usb@fe900000: node has a unit name, but no reg or ranges property Cheers, Diederik Diederik de Haas (10): arm64: dts: rockchip: Move dsi address+size-cells from SoC to px30 boards arm64: dts: rockchip: Move dsi address+size-cells from SoC to rk3399 boards dt-bindings: display: rockchip,dw-mipi-dsi: Drop address/size cells arm64: dts: rockchip: Simplify VOP port definition on rk3328 arm64: dts: rockchip: Simplify edp endpoints on several rk3399 boards arm64: dts: rockchip: Simplify mipi_out endpoint on rk3399 RP64 dtso arm64: dts: rockchip: Move mipi_out node on rk3399 haikou demo dtso arm64: dts: rockchip: Fix LCD panel port on rk3566-pinetab2 arm64: dts: rockchip: Drop unneeded address+size-cells on px30 arm64: dts: rockchip: Drop regulator-compatible property on rk3399 .../rockchip/rockchip,dw-mipi-dsi.yaml | 6 ----- .../rockchip/px30-cobra-ltk050h3146w-a2.dts | 2 ++ .../dts/rockchip/px30-cobra-ltk050h3146w.dts | 2 ++ .../dts/rockchip/px30-cobra-ltk050h3148w.dts | 2 ++ .../dts/rockchip/px30-cobra-ltk500hd1829.dts | 2 ++ arch/arm64/boot/dts/rockchip/px30-evb.dts | 2 ++ .../rockchip/px30-pp1516-ltk050h3146w-a2.dts | 2 ++ .../dts/rockchip/px30-pp1516-ltk050h3148w.dts | 2 ++ arch/arm64/boot/dts/rockchip/px30.dtsi | 6 ----- .../dts/rockchip/rk3326-anbernic-rg351m.dtsi | 2 ++ .../dts/rockchip/rk3326-gameforce-chi.dts | 2 ++ .../boot/dts/rockchip/rk3326-odroid-go.dtsi | 2 ++ arch/arm64/boot/dts/rockchip/rk3328.dtsi | 6 +---- arch/arm64/boot/dts/rockchip/rk3399-base.dtsi | 4 ---- .../dts/rockchip/rk3399-gru-chromebook.dtsi | 15 ++++--------- .../boot/dts/rockchip/rk3399-gru-scarlet.dtsi | 4 +++- .../boot/dts/rockchip/rk3399-hugsun-x99.dts | 2 -- .../boot/dts/rockchip/rk3399-pinebook-pro.dts | 15 ++++--------- .../dts/rockchip/rk3399-pinephone-pro.dts | 2 ++ .../rk3399-puma-haikou-video-demo.dtso | 12 +++++----- .../boot/dts/rockchip/rk3399-rock-4c-plus.dts | 2 -- .../dts/rockchip/rk3399-rockpro64-screen.dtso | 22 ++++++------------- .../rockchip/rk3399-sapphire-excavator.dts | 16 ++++---------- .../boot/dts/rockchip/rk3566-pinetab2.dtsi | 6 ++--- 24 files changed, 54 insertions(+), 84 deletions(-) -- 2.50.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7071CC7EE30 for ; Sun, 29 Jun 2025 13:04:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=A5ubua+pTIhWRxp4ONe5dtixonTifTspYOHJju8dGu0=; b=Kedv4rBAB+9VXQ PfwQE0ElwUEErz4LJ/bbmgyhHtnOeRt4cvPmdyE0/CBMVpeflHdw7BK2wPz3UmM6SWO6ULJJKagQU +2OXlRdrzCLMh+7CKyceYnFk4HH7z+m24KPzqFErx7+lkxsJ9zpVgkNDXKHkPPnEHmyRu4/bhTh0b Ke0nnAGljcP9cL/lIZ2jom8s3+Afpbl1UgP5+2/G87C2VW/kg/+IcPzIAfZ4xHgtMA/V4H+YqWBjD bqXg/k0IYqdK78Yx8Gup5z+lC+ZlB807nee5c85zbc6FLCqaceQrBbmK4HmRndq7naMueRBAQIWS6 YA66S3iUU2sE57V4ZlUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uVriJ-00000000GNB-3wGT; Sun, 29 Jun 2025 13:04:55 +0000 Received: from out-186.mta0.migadu.com ([2001:41d0:1004:224b::ba]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uVrJG-00000000Dj0-12b3 for linux-rockchip@lists.infradead.org; Sun, 29 Jun 2025 12:39:03 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1751200730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=kUTZn3W2htPA/qP+uxKLCOQdjEPViFtFwYmPnrLX6zA=; b=ux99PPjs/gP+9fYBEUUyJ112v3HpFfuLT0xStBbh43QFM67s7agqYqxUqsPVAcBTwsZU/1 Sd6ssxdDeIMaVdXrnvGPMQhAZP/G59eMB4q/IylHgMkO6F+Z/mR5m+SIDhf0+nWKBhpZuG rYyfEyEDQ5/OvLoQmqfQ8dq6NiORnE7RkQEAwhG+JPTmx72yHJZKoqxl18mOTrO1zDQR2A SZIOpugSEhVmg8U9WJ7VwLuqdnwk6MxiQIhzjT5gJZM8fljbbB9dVnUieDyKUibl6HyZ75 pb2ySMgmEL+/Dopg+vWOac5jK6Jr2dCkg1lFV4uA3Pa32HT6CN6VKJr/j3af7A== From: Diederik de Haas To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Dragan Simic , Quentin Schulz , Johan Jonker , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Diederik de Haas Subject: [PATCH v3 00/10] Fix several DTB validation issues Date: Sun, 29 Jun 2025 14:34:41 +0200 Message-ID: <20250629123840.34948-1-didi.debian@cknow.org> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250629_053902_429785_2387F2BF X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org This patch set fixes several DTB validation issues and consists of 2 parts: 1) dsi refactoring 2) various low-hanging fruit ad 1) The display/rockchip/rockchip,dw-mipi-dsi.yaml binding had: - #address-cells - #size-cells My guess is that those properties were added for panel(s) which could be connected. While convenient, it's not a property of the DSI controller (in the SoC). And caused DTB validation issues when a panel was not connected to the board. So add the #address/#size-cells properties to the board dts[i] file where there is a panel and then remove the properties from the SoC dtsi file ... and then from the binding file as well. ad 2) There were a number of issues which were obvious to me how to fix, so I fixed those as well. One of those was the addition of port(s) or endpoints, but for that the context (ie parent nodes) got redefined ... to the same values they had in the SoC dsi node. The SoC dsi node already defined the structure where each port got a label/phandle. That allows for a simplification of the port/endpoint by referencing that label/phandle. My changes were based on yesterday's v6.17-armsoc/dts64 branch: 7f9509791507 ("arm64: dts: rockchip: add DTs for Firefly ROC-RK3588S-PC") Then applied the following patches: 86491c2b99e5 ("dt-bindings: pinctrl: rockchip: increase max amount of device functions") 6f446bbe412a ("dt-bindings: gpu: mali-utgard: Add Rockchip RK3528 compatible") ab9be0b75af5 ("dt-bindings: display: himax-hx8394: Add Huiling hl055fhav028c") 8358102806c6 ("dt-bindings: power: rockchip: Add support for RK3528") 233eda069994 ("dt-bindings: rockchip: pmu: Add compatible for RK3528") And then validated it with W=1 using dtschema-2025.6.1. The validation log file sizes: - base: 99.9 KiB - dsi: 82.2 KiB - low-hanging-fruit: 69.0 KiB I then checked whether dmesg wouldn't indicate problem on these boards: - Rock64 (rk3328) - RockPro64 (rk3399) - PineTab2 (rk3566) And I didn't find any. I don't have any px30 or rk3399-gru-* based boards, so I couldn't test with those. Changes in v2: - Move refactoring of port/endpoint definition to its own patch (Quentin) - Move re-ordering of nodes to its own patch (Quentin) Link to v1: https://lore.kernel.org/linux-rockchip/20250627152645.740981-1-didi.debian@cknow.org/ Changes in v3: - Fix syntax error in RP64 screen dtso (kernel test robot) Link to v2: https://lore.kernel.org/linux-rockchip/20250628144915.839338-1-didi.debian@cknow.org/ I also identified some other items which could reduce the DTB validation 'noise' substantially: "failed to match any schema with compatible" errors: - 'mps,mp8859': regulator/mp8859.txt - 'realtek,rt5651': sound/rt5651.txt - 'rockchip,rk3368-mailbox': mailbox/rockchip-mailbox.txt - 'rockchip,rk3399-gru-sound': sound/rockchip,rk3399-gru-sound.txt - 'ti,tsc2007': input/touchscreen/tsc2007.txt Other issues where a (small?) fix may help a lot: px30: - /isp@ff4a0000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary - /syscon@ff140000/lvds/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary - /dsi@ff450000/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary rk3399: - /usb@fe800000: node has a unit name, but no reg or ranges property - /usb@fe900000: node has a unit name, but no reg or ranges property Cheers, Diederik Diederik de Haas (10): arm64: dts: rockchip: Move dsi address+size-cells from SoC to px30 boards arm64: dts: rockchip: Move dsi address+size-cells from SoC to rk3399 boards dt-bindings: display: rockchip,dw-mipi-dsi: Drop address/size cells arm64: dts: rockchip: Simplify VOP port definition on rk3328 arm64: dts: rockchip: Simplify edp endpoints on several rk3399 boards arm64: dts: rockchip: Simplify mipi_out endpoint on rk3399 RP64 dtso arm64: dts: rockchip: Move mipi_out node on rk3399 haikou demo dtso arm64: dts: rockchip: Fix LCD panel port on rk3566-pinetab2 arm64: dts: rockchip: Drop unneeded address+size-cells on px30 arm64: dts: rockchip: Drop regulator-compatible property on rk3399 .../rockchip/rockchip,dw-mipi-dsi.yaml | 6 ----- .../rockchip/px30-cobra-ltk050h3146w-a2.dts | 2 ++ .../dts/rockchip/px30-cobra-ltk050h3146w.dts | 2 ++ .../dts/rockchip/px30-cobra-ltk050h3148w.dts | 2 ++ .../dts/rockchip/px30-cobra-ltk500hd1829.dts | 2 ++ arch/arm64/boot/dts/rockchip/px30-evb.dts | 2 ++ .../rockchip/px30-pp1516-ltk050h3146w-a2.dts | 2 ++ .../dts/rockchip/px30-pp1516-ltk050h3148w.dts | 2 ++ arch/arm64/boot/dts/rockchip/px30.dtsi | 6 ----- .../dts/rockchip/rk3326-anbernic-rg351m.dtsi | 2 ++ .../dts/rockchip/rk3326-gameforce-chi.dts | 2 ++ .../boot/dts/rockchip/rk3326-odroid-go.dtsi | 2 ++ arch/arm64/boot/dts/rockchip/rk3328.dtsi | 6 +---- arch/arm64/boot/dts/rockchip/rk3399-base.dtsi | 4 ---- .../dts/rockchip/rk3399-gru-chromebook.dtsi | 15 ++++--------- .../boot/dts/rockchip/rk3399-gru-scarlet.dtsi | 4 +++- .../boot/dts/rockchip/rk3399-hugsun-x99.dts | 2 -- .../boot/dts/rockchip/rk3399-pinebook-pro.dts | 15 ++++--------- .../dts/rockchip/rk3399-pinephone-pro.dts | 2 ++ .../rk3399-puma-haikou-video-demo.dtso | 12 +++++----- .../boot/dts/rockchip/rk3399-rock-4c-plus.dts | 2 -- .../dts/rockchip/rk3399-rockpro64-screen.dtso | 22 ++++++------------- .../rockchip/rk3399-sapphire-excavator.dts | 16 ++++---------- .../boot/dts/rockchip/rk3566-pinetab2.dtsi | 6 ++--- 24 files changed, 54 insertions(+), 84 deletions(-) -- 2.50.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip