From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1146422F74A for ; Sun, 29 Jun 2025 20:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751230597; cv=none; b=S56J3qD5+650093jWjHnpPs/pXFxpEETx8I7as7nW1KNxuFd+hY8y18teNpLSz/acb5+ugaV+B99aTR1c/ACsDb9idXWD/FI0F2k9DKYbLeGBw5nNovwZFhG0ydU384DHpoqF9n78TYVx5Yod8hlwlEi58rISe/LqLv42/t4oxI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751230597; c=relaxed/simple; bh=H1hVFrLqQx9qxOhe1aNvAQrEbPdB21UNiSFh2xSwzRM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W/jgjLiuS+ZZZW9k0NwRJuwz9Xyc3LjZlLfzDpX5U4w/MQysswb9eJmZsCaoHvTj1M4u9mrWyHWy44aMp61PjoJA2XDggIJom9phOzwiPqYJS7NvghtmyMcXHMjhqqsye0oxX1Rh7DIz0KXZmdESegd7g0Y3KlxyoJTSTF+kOOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TbiAAiCK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TbiAAiCK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D700C4CEF0; Sun, 29 Jun 2025 20:56:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751230596; bh=H1hVFrLqQx9qxOhe1aNvAQrEbPdB21UNiSFh2xSwzRM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TbiAAiCKCificbpqxFZT3ZllXNqqbqFp0i+tw7P6YTLi68ztA1m3T2/q4vz+Jv3JI b1GCBC+3yeT5rTa6U0KMOy9sJgZE2RsNW41FgRnnuXgTtGSpBgSHQI/kZHP/Dp17Uq /sfs1SpIY2l4tGdjqLczNzoSoDUQBt8cowLZEHSbK4uIOwjN9geu/KetsT1NPNvaOR 4I1cgp8pECeUJGqLg6YLu4CLdFJv1jref/8tZKWQB9/kBs/YdK8uvo/b1HQoB/9p97 iZbqJFAfkdlo4USUD8Qqf/LK3nIO5WWHs/iECcQPWOaXbGesnwHKwdmBKXee2wQX/M JqMq6Uj5YJPQw== From: Hans de Goede To: Sakari Ailus , Laurent Pinchart Cc: Hans de Goede , Mathis Foerst , linux-media@vger.kernel.org Subject: [PATCH v3 01/15] media: aptina-pll: Debug log p1 min and max values Date: Sun, 29 Jun 2025 22:56:11 +0200 Message-ID: <20250629205626.68341-2-hansg@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250629205626.68341-1-hansg@kernel.org> References: <20250629205626.68341-1-hansg@kernel.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make aptina_pll_calculate() debug log the calculated p1 min and max values, this makes it easier to see how the m, n and p1 values were chosen. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- drivers/media/i2c/aptina-pll.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/aptina-pll.c b/drivers/media/i2c/aptina-pll.c index b1f89bbf9d47..cd2ed4583c97 100644 --- a/drivers/media/i2c/aptina-pll.c +++ b/drivers/media/i2c/aptina-pll.c @@ -129,6 +129,8 @@ int aptina_pll_calculate(struct device *dev, p1_max = min(limits->p1_max, limits->out_clock_max * div / (pll->ext_clock * pll->m)); + dev_dbg(dev, "pll: p1 min %u max %u\n", p1_min, p1_max); + for (p1 = p1_max & ~1; p1 >= p1_min; p1 -= 2) { unsigned int mf_inc = p1 / gcd(div, p1); unsigned int mf_high; -- 2.49.0