From: Jakub Kicinski <kuba@kernel.org>
To: Ido Schimmel <idosch@idosch.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
syzbot+430f9f76633641a62217@syzkaller.appspotmail.com,
andrew@lunn.ch, maxime.chevallier@bootlin.com
Subject: Re: [PATCH net-next] net: ethtool: avoid OOB accesses in PAUSE_SET
Date: Mon, 30 Jun 2025 08:20:37 -0700 [thread overview]
Message-ID: <20250630082037.4ac5d518@kernel.org> (raw)
In-Reply-To: <aGEPszpq9eojNF4Y@shredder>
On Sun, 29 Jun 2025 13:04:35 +0300 Ido Schimmel wrote:
> On Thu, Jun 26, 2025 at 04:39:26PM -0700, Jakub Kicinski wrote:
> > We now reuse .parse_request() from GET on SET, so we need to make sure
> > that the policies for both cover the attributes used for .parse_request().
> > genetlink will only allocate space in info->attrs for ARRAY_SIZE(policy).
> >
> > Reported-by: syzbot+430f9f76633641a62217@syzkaller.appspotmail.com
> > Fixes: 963781bdfe20 ("net: ethtool: call .parse_request for SET handlers")
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> Tested-by: Ido Schimmel <idosch@nvidia.com>
>
> Thanks, we hit that as well.
>
> BTW, shouldn't you also release the reference from the net device if
> ethnl_default_parse() fails in ethnl_default_set_doit()?
Oof, good catch! Let me remove this trap of an API :S
next prev parent reply other threads:[~2025-06-30 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 23:39 [PATCH net-next] net: ethtool: avoid OOB accesses in PAUSE_SET Jakub Kicinski
2025-06-29 10:04 ` Ido Schimmel
2025-06-30 15:20 ` Jakub Kicinski [this message]
2025-06-30 15:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250630082037.4ac5d518@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@idosch.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+430f9f76633641a62217@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.