From: Simon Horman <horms@kernel.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: johndale@cisco.com, neescoba@cisco.com, benve@cisco.com,
satishkh@cisco.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net] enic: fix incorrect MTU comparison in enic_change_mtu()
Date: Mon, 30 Jun 2025 11:58:26 +0100 [thread overview]
Message-ID: <20250630105826.GC41770@horms.kernel.org> (raw)
In-Reply-To: <20250628145612.476096-1-alok.a.tiwari@oracle.com>
On Sat, Jun 28, 2025 at 07:56:05AM -0700, Alok Tiwari wrote:
> The comparison in enic_change_mtu() incorrectly used the current
> netdev->mtu instead of the new new_mtu value when warning about
> an MTU exceeding the port MTU. This could suppress valid warnings
> or issue incorrect ones.
>
> Fix the condition and log to properly reflect the new_mtu.
>
> Fixes: ab123fe071c9 ("enic: handle mtu change for vf properly")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-06-30 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 14:56 [PATCH net] enic: fix incorrect MTU comparison in enic_change_mtu() Alok Tiwari
2025-06-30 10:58 ` Simon Horman [this message]
2025-07-02 2:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250630105826.GC41770@horms.kernel.org \
--to=horms@kernel.org \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johndale@cisco.com \
--cc=kuba@kernel.org \
--cc=neescoba@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=satishkh@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.