Re: [PATCH] net: atlantic: Rename PCI driver struct to end in _driver

[Simon Horman <horms@kernel.org>]

On Fri, Jun 27, 2025 at 11:18:45PM +0200, Uwe Kleine-König wrote:
> Hello Simon,
> 
> On Fri, Jun 27, 2025 at 08:47:52PM +0100, Simon Horman wrote:
> > On Fri, Jun 27, 2025 at 11:46:41AM +0200, Uwe Kleine-König wrote:
> > > This is not only a cosmetic change because the section mismatch checks
> > > also depend on the name and for drivers the checks are stricter than for
> > > ops.
> > > 
> > > However aq_pci_driver also passes the stricter checks just fine, so no
> > > further changes needed.
> > > 
> > > Fixes: 97bde5c4f909 ("net: ethernet: aquantia: Support for NIC-specific code")
> > 
> > From a Networking subsystem point of view
> > this feels more like an enhancement than a bug fix.
> > Can we drop the Fixes tag?
> 
> I think it's right to include it, but I won't argue if you apply the
> patch without it.

For Networking we generally use Fixes tags for bug fixes,
which in general address some adverse user-visible behaviour,
e.g. a panic.

Of course there is always room for interpretation. But based
on my understanding of this patch I would lean towards it
not being a bug fix. Again, in the sense that bug fix is usually
used for networking patches.

So I would suggest:

1. Target the patch (and others like it) at net-next

   Subject: [PATCH net-next] ...

2. Don't include a Fixes tag

3. Optionally refer to the patch that introduced the problem by
   using the following in the commit message.

   commit 97bde5c4f909 ("net: ethernet: aquantia: Support for NIC-specific
   code")

Thanks in advance for taking my opinion into consideration.