From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a05:7300:232a:b0:178:84eb:402c with SMTP id r42csp2439432dye; Mon, 30 Jun 2025 05:37:29 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWuwMIhusOSKQs5IAOVdaqicowNncsiw0BCXmdqCnSa1VojXMb1w/bkv63wT9rT/Msi6k60vz6h+XuaLQ==@linaro.org X-Google-Smtp-Source: AGHT+IG7BJWE4mkYr5ek3FBpoTtEcePv7Ft2AjMrpWpkvk1LsjqJ77st/XVOBmZGByZCbE6EttoI X-Received: by 2002:a05:6000:400b:b0:3a5:5270:c38f with SMTP id ffacd0b85a97d-3a8ff8f52c3mr10808101f8f.0.1751287048809; Mon, 30 Jun 2025 05:37:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1751287048; cv=none; d=google.com; s=arc-20240605; b=e9nJQBulu8tjCCbwKvu+tl3GRbbKnC6lFLYtQTEYMl5NmyzG7maI7p/RCdvwPzzG/V HINwUFvM7rlxaCeGFDlonSpeHdUxoNkL1s9/nlD+3XeP4TuBfZQsOsd1Xgw2laxdJVvP GFXtleXeFSDK1t4bhCNBY50tbfsgMA+ujkJZu3aHqL+mubBZyye51GcsA/wXhqLkWWzm B6D3C1U/HB2rtmFUS71jz2ztcy6JlV1g3tx6OrsPQ+QEuhIVyzO9grBvRaiAm7HUPHmt YXyWT28ElWp3NrMWY7qBHvY5kjwqS+pQvgI8wmZMfqIdlNWGKFoCMMAe4eulHeVOaj6Q jrjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=yJtlP0EXLmXubRHE1CGHA792gVx+8Yk8cTP6lCrzt/8=; fh=De5j/+RFiHp5oysg/kfBHcT9O0ASuV5hpNukEk4skqM=; b=W5FRHPMGogeFRS2CSpHJvr/pdt/6fcBeI5+px22nO6uOOdUl1V8+DUsfhOv+qf25qC PVaocEPn3X7O6VJ/XYF9mjIgh2C5HeT852yt+ujKK53FB/iMgwlfTiVbXbvrvnQhqBlY cRwyvDM/VHz1XjkbUsk0TpbRdiMPcp1gk3tjyHZu+6Wbf15FVttr1BuhofbRIAQDc9k/ wXaQWSKa6wDTx3ucu9y6I2C9qj/UaJaMu5CGm0RfwhfuoKFYFsDZGlgrdoSLsnkvtlDU jvQvIMx0+G2i5xhuqFA+JbrbFtoL37hmyrP0PfOwg4caT8E+hTdiKSWI17RTo+jc+pI0 H2KA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from frasgout.his.huawei.com (frasgout.his.huawei.com. [185.176.79.56]) by mx.google.com with ESMTPS id ffacd0b85a97d-3a8a081fb2asi5657160f8f.823.2025.06.30.05.37.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jun 2025 05:37:28 -0700 (PDT) Received-SPF: pass (google.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) client-ip=185.176.79.56; Authentication-Results: mx.google.com; spf=pass (google.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4bW5Jh4NHCz6L5dv; Mon, 30 Jun 2025 20:37:08 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 0EB8F140417; Mon, 30 Jun 2025 20:37:28 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 30 Jun 2025 14:37:16 +0200 Date: Mon, 30 Jun 2025 13:37:14 +0100 From: Jonathan Cameron To: Eric Auger CC: , , , , , , , , , , , Subject: Re: [PATCH v4 24/32] hw/acpi/pcihp: Remove root arg in acpi_pcihp_init Message-ID: <20250630133714.00000060@huawei.com> In-Reply-To: <20250627095620.3300028-25-eric.auger@redhat.com> References: <20250627095620.3300028-1-eric.auger@redhat.com> <20250627095620.3300028-25-eric.auger@redhat.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100009.china.huawei.com (7.191.174.83) To frapeml500008.china.huawei.com (7.182.85.71) X-TUID: EwUgj9bWI0l+ On Fri, 27 Jun 2025 11:55:13 +0200 Eric Auger wrote: > Let pass the root bus to ich9 and piix4 through a property link > instead of through an argument passed to acpi_pcihp_init(). > > Also make sure the root bus is set at the entry of acpi_pcihp_init(). > > The rationale of that change is to be consistent with the forecoming ARM > implementation where the machine passes the root bus (steming from GPEX) > to the GED device through a link property. > > Signed-off-by: Eric Auger > Suggested-by: Igor Mammedov Seems reasonable to me. Reviewed-by: Jonathan Cameron From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 532F0C8302D for ; Mon, 30 Jun 2025 12:38:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uWDlV-0001uI-LX; Mon, 30 Jun 2025 08:37:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uWDlT-0001qx-Gf; Mon, 30 Jun 2025 08:37:39 -0400 Received: from [185.176.79.56] (helo=frasgout.his.huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uWDlP-0006qw-4l; Mon, 30 Jun 2025 08:37:38 -0400 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4bW5Jh4NHCz6L5dv; Mon, 30 Jun 2025 20:37:08 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 0EB8F140417; Mon, 30 Jun 2025 20:37:28 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 30 Jun 2025 14:37:16 +0200 Date: Mon, 30 Jun 2025 13:37:14 +0100 To: Eric Auger CC: , , , , , , , , , , , Subject: Re: [PATCH v4 24/32] hw/acpi/pcihp: Remove root arg in acpi_pcihp_init Message-ID: <20250630133714.00000060@huawei.com> In-Reply-To: <20250627095620.3300028-25-eric.auger@redhat.com> References: <20250627095620.3300028-1-eric.auger@redhat.com> <20250627095620.3300028-25-eric.auger@redhat.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100009.china.huawei.com (7.191.174.83) To frapeml500008.china.huawei.com (7.182.85.71) X-Host-Lookup-Failed: Reverse DNS lookup failed for 185.176.79.56 (deferred) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.237, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, 27 Jun 2025 11:55:13 +0200 Eric Auger wrote: > Let pass the root bus to ich9 and piix4 through a property link > instead of through an argument passed to acpi_pcihp_init(). > > Also make sure the root bus is set at the entry of acpi_pcihp_init(). > > The rationale of that change is to be consistent with the forecoming ARM > implementation where the machine passes the root bus (steming from GPEX) > to the GED device through a link property. > > Signed-off-by: Eric Auger > Suggested-by: Igor Mammedov Seems reasonable to me. Reviewed-by: Jonathan Cameron