From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com
Subject: Re: [PATCH resend] rtc: Rename lib_test to rtc_lib_test
Date: Mon, 30 Jun 2025 15:54:27 +0200 [thread overview]
Message-ID: <20250630135427faa6c326@mail.local> (raw)
In-Reply-To: <df1a73d4a14426ae0d3e8809aed40c686b67dd3e.1751268290.git.geert@linux-m68k.org>
On 30/06/2025 09:47:54+0200, Geert Uytterhoeven wrote:
> When compiling the RTC library functions test as a module, the module
> has the non-descriptive name "lib_test.ko". Fix this by adding the
> subsystem's name as a prefix.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/rtc/Makefile | 2 +-
> drivers/rtc/{lib_test.c => rtc_lib_test.c} | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename drivers/rtc/{lib_test.c => rtc_lib_test.c} (100%)
>
> diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile
> index 4619aa2ac4697591..aa08d1c8a32ec23d 100644
> --- a/drivers/rtc/Makefile
> +++ b/drivers/rtc/Makefile
> @@ -15,7 +15,7 @@ rtc-core-$(CONFIG_RTC_INTF_DEV) += dev.o
> rtc-core-$(CONFIG_RTC_INTF_PROC) += proc.o
> rtc-core-$(CONFIG_RTC_INTF_SYSFS) += sysfs.o
>
> -obj-$(CONFIG_RTC_LIB_KUNIT_TEST) += lib_test.o
> +obj-$(CONFIG_RTC_LIB_KUNIT_TEST) += rtc_lib_test.o
I'd rather have test_rtc_lib as only the drivers are currently prefixed with
rtc.
>
> # Keep the list ordered.
>
> diff --git a/drivers/rtc/lib_test.c b/drivers/rtc/rtc_lib_test.c
> similarity index 100%
> rename from drivers/rtc/lib_test.c
> rename to drivers/rtc/rtc_lib_test.c
> --
> 2.43.0
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-06-30 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 7:47 [PATCH resend] rtc: Rename lib_test to rtc_lib_test Geert Uytterhoeven
2025-06-30 13:54 ` Alexandre Belloni [this message]
2025-07-01 7:45 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250630135427faa6c326@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=geert@linux-m68k.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=rmoar@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.