From: "Darrick J. Wong" <djwong@kernel.org>
To: Samuel Smith <satlug@net153.net>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2scrub: honor fstrim setting in e2scrub.conf
Date: Mon, 30 Jun 2025 08:19:45 -0700 [thread overview]
Message-ID: <20250630151945.GC9987@frogsfrogsfrogs> (raw)
In-Reply-To: <20250628051415.3015410-1-satlug@net153.net>
On Sat, Jun 28, 2025 at 12:14:15AM -0500, Samuel Smith wrote:
> The systemd service unconditionally passes -t to e2scrub, forcing
> fstrim to run after every scrub regardless of the fstrim setting
> in /etc/e2scrub.conf. Removing the hardcoded flag will allow users to
> control the behavior via the configuration file.
>
> Signed-off-by: Samuel Smith <satlug@net153.net>
Now that there's a config file, we can indeed drop the explicit -t.
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> scrub/e2scrub@.service.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scrub/e2scrub@.service.in b/scrub/e2scrub@.service.in
> index 6425263c..3c9893c5 100644
> --- a/scrub/e2scrub@.service.in
> +++ b/scrub/e2scrub@.service.in
> @@ -16,5 +16,5 @@ User=root
> IOSchedulingClass=idle
> CPUSchedulingPolicy=idle
> Environment=SERVICE_MODE=1
> -ExecStart=@root_sbindir@/e2scrub -t %f
> +ExecStart=@root_sbindir@/e2scrub %f
> SyslogIdentifier=%N
> --
> 2.39.5
>
>
next prev parent reply other threads:[~2025-06-30 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 5:14 [PATCH] e2scrub: honor fstrim setting in e2scrub.conf Samuel Smith
2025-06-30 15:19 ` Darrick J. Wong [this message]
2025-07-02 2:00 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250630151945.GC9987@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=satlug@net153.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.