From: Jakub Kicinski <kuba@kernel.org>
To: Harshitha Ramamurthy <hramamurthy@google.com>
Cc: netdev@vger.kernel.org, jeroendb@google.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, willemb@google.com, bcf@google.com,
pkaligineedi@google.com, joshwash@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] gve: make IRQ handlers and page allocation NUMA aware
Date: Mon, 30 Jun 2025 19:06:45 -0700 [thread overview]
Message-ID: <20250630190645.5423949e@kernel.org> (raw)
In-Reply-To: <20250627183141.3781516-1-hramamurthy@google.com>
On Fri, 27 Jun 2025 18:31:41 +0000 Harshitha Ramamurthy wrote:
> - rx->qpl_copy_pool = kvcalloc(rx->qpl_copy_pool_mask + 1,
> - sizeof(rx->qpl_copy_pool[0]),
> - GFP_KERNEL);
> + rx->qpl_copy_pool =
> + kvzalloc_node(array_size(rx->qpl_copy_pool_mask + 1,
> + sizeof(rx->qpl_copy_pool[0])),
> + GFP_KERNEL, priv->numa_node);
>
> if (!rx->qpl_copy_pool) {
kvcalloc_node() exists for more than a year now.
nit: when you respin could you shift the allocation so that the empty
line appears before the kvcalloc_node() call rather than between it
and the error check?
--
pw-bot: cr
prev parent reply other threads:[~2025-07-01 2:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 18:31 [PATCH net-next] gve: make IRQ handlers and page allocation NUMA aware Harshitha Ramamurthy
2025-07-01 2:06 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250630190645.5423949e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bcf@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=joshwash@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.