From: Bjorn Helgaas <helgaas@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 3/4] PCI: dwc: Add debugfs support for PTM context
Date: Mon, 30 Jun 2025 15:51:58 -0500 [thread overview]
Message-ID: <20250630205158.GA1809065@bhelgaas> (raw)
In-Reply-To: <20250617231210.GA1172093@bhelgaas>
On Tue, Jun 17, 2025 at 06:12:10PM -0500, Bjorn Helgaas wrote:
> On Mon, May 05, 2025 at 07:54:41PM +0530, Manivannan Sadhasivam wrote:
> > Synopsys Designware PCIe IPs support PTM capability as defined in the PCIe
> > spec r6.0, sec 6.21. The PTM context information is exposed through Vendor
> > Specific Extended Capability (VSEC) registers on supported controller
> > implementation.
>
> > +const struct pcie_ptm_ops dw_pcie_ptm_ops = {
>
> Sparse complains:
>
> CHECK drivers/pci/controller/dwc/pcie-designware-debugfs.c
> drivers/pci/controller/dwc/pcie-designware-debugfs.c:868:27: warning: symbol 'dw_pcie_ptm_ops' was not declared. Should it be static?
>
> I should have noticed this earlier, sorry. As of v6.16-rc1, this is
> now 852a1fdd34a8 ("PCI: dwc: Add debugfs support for PTM context")
> upstream.
Keeping this warm so we remember to fix it eventually.
next prev parent reply other threads:[~2025-06-30 20:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 14:24 [PATCH v4 0/4] PCI: Add PTM debugfs support Manivannan Sadhasivam
2025-05-05 14:24 ` [PATCH v4 1/4] PCI: Add debugfs support for exposing PTM context Manivannan Sadhasivam
2025-05-05 18:37 ` Bjorn Helgaas
2025-05-10 6:20 ` Manivannan Sadhasivam
2025-06-07 2:55 ` Eric Biggers
2025-05-05 14:24 ` [PATCH v4 2/4] PCI: dwc: Pass DWC PCIe mode to dwc_pcie_debugfs_init() Manivannan Sadhasivam
2025-05-05 18:37 ` Bjorn Helgaas
2025-05-10 6:21 ` Manivannan Sadhasivam
2025-05-05 14:24 ` [PATCH v4 3/4] PCI: dwc: Add debugfs support for PTM context Manivannan Sadhasivam
2025-06-17 23:12 ` Bjorn Helgaas
2025-06-30 20:51 ` Bjorn Helgaas [this message]
2025-05-05 14:24 ` [PATCH v4 4/4] PCI: qcom-ep: Mask PTM_UPDATING interrupt Manivannan Sadhasivam
2025-05-10 6:20 ` [PATCH v4 0/4] PCI: Add PTM debugfs support Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250630205158.GA1809065@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.