From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FD38C7EE30 for ; Tue, 1 Jul 2025 09:09:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 198DC10E57F; Tue, 1 Jul 2025 09:09:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="kHIatlvj"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2722910E57F; Tue, 1 Jul 2025 09:09:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751360955; x=1782896955; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FrfjJJnouuxGCdL2h2tdZJ+mC2yN9qtKD1DgtGHeWDc=; b=kHIatlvj8WxW3eFeiK+KMQi0Znf1Dd4ygaXyDWyyKBJJakJLUIp4Q7Ht IhR2iHKA0UqZdfxReBvxLUu6ldIiHlILPHz0RMJZa8zvrXI9aZT2jQVwK wp+mGMU1NJ1BbL3i4VrsUMuNnLDC+qYFmxCHD0u7LQH+IDAN+Ia0ZLSM5 CKUTFtKq0ZGgbh6YHv3sJcMLHSu8BJSTA5V+Tly3dy9OouDKr2fbXbjiV +Qsp0jQ2nhKWZ917z6l8GY7JIM08sNYABOD1BtPgRTi+u5/BRdeKMOZMs mRwylSnfTQBKsHd9dX742qnWgeb9J0O6J/Iiz/0ho7GLxjG7grm9Wkw2D w==; X-CSE-ConnectionGUID: bMo+boDaSouNfKY49jFjcQ== X-CSE-MsgGUID: gLspmGn0QvCceYkgY6FhYQ== X-IronPort-AV: E=McAfee;i="6800,10657,11480"; a="64218648" X-IronPort-AV: E=Sophos;i="6.16,279,1744095600"; d="scan'208";a="64218648" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2025 02:09:15 -0700 X-CSE-ConnectionGUID: UpzcO0kuTMKFr9qDJXDwZA== X-CSE-MsgGUID: OX+YrKmWRs2CdRps3ZJEgg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,279,1744095600"; d="scan'208";a="159427410" Received: from zzombora-mobl1.ger.corp.intel.com (HELO stinkbox) ([10.245.245.11]) by orviesa005.jf.intel.com with SMTP; 01 Jul 2025 02:09:12 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 01 Jul 2025 12:09:10 +0300 From: Ville Syrjala To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Thomas Zimmermann , Laurent Pinchart Subject: [PATCH v2 19/19] drm: Make passing of format info to drm_helper_mode_fill_fb_struct() mandatory Date: Tue, 1 Jul 2025 12:07:22 +0300 Message-ID: <20250701090722.13645-20-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250701090722.13645-1-ville.syrjala@linux.intel.com> References: <20250701090722.13645-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Ville Syrjälä Now that everyone passes along the format info to drm_helper_mode_fill_fb_struct() we can make this behaviour mandatory and drop the extra lookup. Reviewed-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_modeset_helper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_modeset_helper.c b/drivers/gpu/drm/drm_modeset_helper.c index 89ba99970735..988735560570 100644 --- a/drivers/gpu/drm/drm_modeset_helper.c +++ b/drivers/gpu/drm/drm_modeset_helper.c @@ -88,8 +88,7 @@ void drm_helper_mode_fill_fb_struct(struct drm_device *dev, int i; fb->dev = dev; - fb->format = info ? : drm_get_format_info(dev, mode_cmd->pixel_format, - mode_cmd->modifier[0]); + fb->format = info; fb->width = mode_cmd->width; fb->height = mode_cmd->height; for (i = 0; i < 4; i++) { -- 2.49.0