From: Simon Horman <horms@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Igor Russkikh <irusskikh@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexander Loktionov <Alexander.Loktionov@aquantia.com>,
David VomLehn <vomlehn@texas.net>,
Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>,
Pavel Belous <Pavel.Belous@aquantia.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: atlantic: Rename PCI driver struct to end in _driver
Date: Tue, 1 Jul 2025 14:29:48 +0100 [thread overview]
Message-ID: <20250701132948.GS41770@horms.kernel.org> (raw)
In-Reply-To: <20250630164406.57589-2-u.kleine-koenig@baylibre.com>
On Mon, Jun 30, 2025 at 06:44:07PM +0200, Uwe Kleine-König wrote:
> This is not only a cosmetic change because the section mismatch checks
> (implemented in scripts/mod/modpost.c) also depend on the object's name
> and for drivers the checks are stricter than for ops.
>
> However aq_pci_driver also passes the stricter checks just fine, so no
> further changes needed.
>
> The cheating^Wmisleading name was introduced in commit 97bde5c4f909
> ("net: ethernet: aquantia: Support for NIC-specific code")
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Changes since implicit v1 (available at
> https://lore.kernel.org/netdev/20250627094642.1923993-2-u.kleine-koenig@baylibre.com):
>
> - Improve commit log to explain in more detail the check
> - Mention the introducing commit in prose and not in a Fixes: line
> - trivially rebase to a newer next tag
> - explicitly mark for net-next in the Subject line
Thanks for your patience and making these updates.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-07-01 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 16:44 [PATCH v2 net-next] net: atlantic: Rename PCI driver struct to end in _driver Uwe Kleine-König
2025-07-01 13:29 ` Simon Horman [this message]
2025-07-02 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250701132948.GS41770@horms.kernel.org \
--to=horms@kernel.org \
--cc=Alexander.Loktionov@aquantia.com \
--cc=Dmitry.Bezrukov@aquantia.com \
--cc=Pavel.Belous@aquantia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=vomlehn@texas.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.