From: Jakub Kicinski <kuba@kernel.org>
To: Mingming Cao <mmc@linux.ibm.com>
Cc: netdev@vger.kernel.org, bjking1@linux.ibm.com,
haren@linux.ibm.com, ricklind@linux.ibm.com,
Dave Marquardt <davemarq@linux.ibm.com>
Subject: Re: [PATCH net-next 1/4] ibmvnic: Derive NUM_RX_STATS/NUM_TX_STATS dynamically
Date: Tue, 1 Jul 2025 18:30:16 -0700 [thread overview]
Message-ID: <20250701183016.26212cec@kernel.org> (raw)
In-Reply-To: <20250630234806.10885-2-mmc@linux.ibm.com>
On Mon, 30 Jun 2025 16:48:03 -0700 Mingming Cao wrote:
> Replace the hardcoded #define NUM_RX_STATS/NUM_TX_STATS 3
> with a sizeof-based calculation to automatically reflect
> the number of fields in struct ibmvnic_rx_queue_stats.
> and struct ibmvnic_tx_queue_stats.
>
> This avoids mismatches and improves maintainability.
>
> Fixes: 2ee73c54a615 ("ibmvnic: Add stat for tx direct vs tx batched")
Fixes tags are for changes which fix user-visible bugs. Please remove
next prev parent reply other threads:[~2025-07-02 1:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 23:48 [PATCH net-next 0/4] ibmvnic: Improve queue stats and subcrq indirect handling Mingming Cao
2025-06-30 23:48 ` [PATCH net-next 1/4] ibmvnic: Derive NUM_RX_STATS/NUM_TX_STATS dynamically Mingming Cao
2025-07-02 1:30 ` Jakub Kicinski [this message]
2025-06-30 23:48 ` [PATCH net-next 2/4] ibmvnic: Use atomic64_t for queue stats Mingming Cao
2025-07-03 2:58 ` kernel test robot
2025-06-30 23:48 ` [PATCH net-next 3/4] ibmvnic: Use ndo_get_stats64 to fix inaccurate SAR reporting Mingming Cao
2025-06-30 23:48 ` [PATCH net-next 4/4] ibmvnic: Make max subcrq indirect entries tunable via module param Mingming Cao
2025-07-02 1:31 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250701183016.26212cec@kernel.org \
--to=kuba@kernel.org \
--cc=bjking1@linux.ibm.com \
--cc=davemarq@linux.ibm.com \
--cc=haren@linux.ibm.com \
--cc=mmc@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ricklind@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.