From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
andrew@lunn.ch, przemyslaw.kitszel@intel.com,
anthony.l.nguyen@intel.com, sgoutham@marvell.com,
gakula@marvell.com, sbhatta@marvell.com, bbhushan2@marvell.com,
tariqt@nvidia.com, mbloch@nvidia.com, leon@kernel.org,
ecree.xilinx@gmail.com
Subject: Re: [PATCH net-next 3/5] eth: mlx5: migrate to the *_rxfh_context ops
Date: Tue, 1 Jul 2025 19:43:09 -0700 [thread overview]
Message-ID: <20250701194309.1dcb7467@kernel.org> (raw)
In-Reply-To: <14654215-aa09-48c5-a12d-9fa99bb9e2cc@nvidia.com>
On Tue, 1 Jul 2025 09:25:41 +0300 Gal Pressman wrote:
> > + mlx5e_rx_res_rss_get_rxfh(priv->rx_res, rxfh->rss_context,
> > + ethtool_rxfh_context_indir(ctx),
> > + ethtool_rxfh_context_key(ctx),
> > + &ctx->hfunc, &symmetric);
>
> We don't expect it to fail so no return value check here, but maybe a
> WARN_ON_ONCE() should be added?
Hm.. you know what, I think I'll pop that WARN_ON_ONCE() inside
mlx5e_rx_res_rss_get_rxfh() and make it return void. Core doesn't
call get_rxfh for custom contexts any more, the only calls to
mlx5e_rx_res_rss_get_rxfh() are this one right after creation
and the one that asks for context 0, which I suppose must always exist.
next prev parent reply other threads:[~2025-07-02 2:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 16:09 [PATCH net-next 0/5] net: migrate remaining drivers to dedicated _rxfh_context ops Jakub Kicinski
2025-06-30 16:09 ` [PATCH net-next 1/5] eth: otx2: migrate to the *_rxfh_context ops Jakub Kicinski
2025-06-30 16:09 ` [PATCH net-next 2/5] eth: ice: drop the dead code related to rss_contexts Jakub Kicinski
2025-06-30 16:09 ` [PATCH net-next 3/5] eth: mlx5: migrate to the *_rxfh_context ops Jakub Kicinski
2025-06-30 16:58 ` Gal Pressman
2025-07-01 6:25 ` Gal Pressman
2025-07-02 2:43 ` Jakub Kicinski [this message]
2025-06-30 16:09 ` [PATCH net-next 4/5] net: ethtool: remove the compat code for _rxfh_context ops Jakub Kicinski
2025-07-01 2:13 ` kernel test robot
2025-07-01 6:26 ` Gal Pressman
2025-06-30 16:09 ` [PATCH net-next 5/5] net: ethtool: reduce indent " Jakub Kicinski
2025-07-01 6:26 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250701194309.1dcb7467@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=leon@kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.