From: "Paul E. McKenney" <paulmck@kernel.org>
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
rostedt@goodmis.org, Christoph Hellwig <hch@infradead.org>,
"Paul E. McKenney" <paulmck@kernel.org>
Subject: [PATCH v2 3/5] rcutorture: Remove support for SRCU-lite
Date: Tue, 1 Jul 2025 17:23:28 -0700 [thread overview]
Message-ID: <20250702002330.1074433-3-paulmck@kernel.org> (raw)
In-Reply-To: <2994ade2-bd06-4ba7-bcc9-be4d0d15ea0c@paulmck-laptop>
Because SRCU-lite is being replaced by SRCU-fast, this commit removes
support for SRCU-lite from rcutorture.c
Both SRCU-lite and SRCU-fast provide faster readers by dropping the
smp_mb() call from their lock and unlock primitives, but incur a pair
of added RCU grace periods during the SRCU grace period. There is a
trivial mapping from the SRCU-lite API to that of SRCU-fast, so there
should be no transition issues.
[ paulmck: Apply Christoph Hellwig feedback. ]
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
include/linux/srcu.h | 2 +-
kernel/rcu/rcutorture.c | 7 -------
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/include/linux/srcu.h b/include/linux/srcu.h
index 900b0d5c05f54..c20dacb563e55 100644
--- a/include/linux/srcu.h
+++ b/include/linux/srcu.h
@@ -49,7 +49,7 @@ int init_srcu_struct(struct srcu_struct *ssp);
#define SRCU_READ_FLAVOR_LITE 0x4 // srcu_read_lock_lite().
#define SRCU_READ_FLAVOR_FAST 0x8 // srcu_read_lock_fast().
#define SRCU_READ_FLAVOR_ALL (SRCU_READ_FLAVOR_NORMAL | SRCU_READ_FLAVOR_NMI | \
- SRCU_READ_FLAVOR_LITE | SRCU_READ_FLAVOR_FAST) // All of the above.
+ SRCU_READ_FLAVOR_FAST) // All of the above.
#define SRCU_READ_FLAVOR_SLOWGP (SRCU_READ_FLAVOR_LITE | SRCU_READ_FLAVOR_FAST)
// Flavors requiring synchronize_rcu()
// instead of smp_mb().
diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index 213f23f20a64b..7a893d51d02b6 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -718,11 +718,6 @@ static int srcu_torture_read_lock(void)
WARN_ON_ONCE(idx & ~0x1);
ret += idx << 1;
}
- if (reader_flavor & SRCU_READ_FLAVOR_LITE) {
- idx = srcu_read_lock_lite(srcu_ctlp);
- WARN_ON_ONCE(idx & ~0x1);
- ret += idx << 2;
- }
if (reader_flavor & SRCU_READ_FLAVOR_FAST) {
scp = srcu_read_lock_fast(srcu_ctlp);
idx = __srcu_ptr_to_ctr(srcu_ctlp, scp);
@@ -756,8 +751,6 @@ static void srcu_torture_read_unlock(int idx)
WARN_ON_ONCE((reader_flavor && (idx & ~reader_flavor)) || (!reader_flavor && (idx & ~0x1)));
if (reader_flavor & SRCU_READ_FLAVOR_FAST)
srcu_read_unlock_fast(srcu_ctlp, __srcu_ctr_to_ptr(srcu_ctlp, (idx & 0x8) >> 3));
- if (reader_flavor & SRCU_READ_FLAVOR_LITE)
- srcu_read_unlock_lite(srcu_ctlp, (idx & 0x4) >> 2);
if (reader_flavor & SRCU_READ_FLAVOR_NMI)
srcu_read_unlock_nmisafe(srcu_ctlp, (idx & 0x2) >> 1);
if ((reader_flavor & SRCU_READ_FLAVOR_NORMAL) || !(reader_flavor & SRCU_READ_FLAVOR_ALL))
--
2.40.1
next prev parent reply other threads:[~2025-07-02 0:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 16:13 [PATCH 0/5] Remove SRCU-lite in favor of SRCU-fast Paul E. McKenney
2025-06-24 16:13 ` [PATCH 1/5] torture: Remove support for SRCU-lite Paul E. McKenney
2025-06-25 12:05 ` Christoph Hellwig
2025-06-26 10:54 ` Paul E. McKenney
2025-06-26 11:03 ` Christoph Hellwig
2025-06-26 14:37 ` Paul E. McKenney
2025-06-24 16:13 ` [PATCH 2/5] rcutorture: Remove SRCU-lite scenarios Paul E. McKenney
2025-06-24 16:13 ` [PATCH 3/5] rcutorture: Remove support for SRCU-lite Paul E. McKenney
2025-06-24 16:13 ` [PATCH 4/5] srcu: Remove SRCU-lite implementation Paul E. McKenney
2025-06-24 16:14 ` [PATCH 5/5] checkpatch: Remove SRCU-lite deprecation Paul E. McKenney
2025-07-02 0:23 ` [PATCH v2 0/5] Remove SRCU-lite in favor of SRCU-fast Paul E. McKenney
2025-07-02 0:23 ` [PATCH v2 1/5] torture: Remove support for SRCU-lite Paul E. McKenney
2025-07-02 0:23 ` [PATCH v2 2/5] rcutorture: Remove SRCU-lite scenarios Paul E. McKenney
2025-07-02 0:23 ` Paul E. McKenney [this message]
2025-07-02 0:23 ` [PATCH v2 4/5] srcu: Remove SRCU-lite implementation Paul E. McKenney
2025-07-02 0:23 ` [PATCH v2 5/5] checkpatch: Remove SRCU-lite deprecation Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250702002330.1074433-3-paulmck@kernel.org \
--to=paulmck@kernel.org \
--cc=hch@infradead.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.