From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C0E02E498D for ; Wed, 2 Jul 2025 18:28:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751480929; cv=none; b=RvMuFRIn3URLBQBA0vJFg3L4MOmFbrXuBKARtvYFT4Wi+m08Qi070a012MXrCzYOiliLy+BaZw3C0OYu4DcsziMM1Ps041P5TjkeZptOMGWf/QI3k1dEzn+xt2M89IppgcBrOYvE797naOYtBOGtShdU4R+3BHr13mkUZilujzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751480929; c=relaxed/simple; bh=avUNtvZK0fUa7aGIuYOyPWZE1iep4kiK5Bl0okgHHA8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GtF3HGiewwvnlo1ucUaN1WgK6xd6aorANyF5n1zhFbPJdGkSkyy8s4t59j4NcdLymxZ7GrOi1WYhHuOTzS8rpGiobX6dtkxCZZXxlVsSOw8QSYdI1peceUfLEBzlmmSppbJD9mSvzmIKqNRvC30H5OQEpx7yP1Hsw1ZydTdgclA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=CKnVJuhy; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="CKnVJuhy" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-742c3d06de3so5779594b3a.0 for ; Wed, 02 Jul 2025 11:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1751480927; x=1752085727; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=46MgjvV3epJBZdXixG7o02s3aaxSYe96C/POTn0IK/4=; b=CKnVJuhyqDW5v+l53C2hT1fONwq8LkyRwXuQlUE8TP6Tiuk0uDEcbyM/pfua9Mr4fv VoQLwFamC0UsbQLQXU+FPEQ6YYgc0AotqxO44BpFok8cZc1iGCHD66Lkng7cdHwyXdDG lOythuhDKPjjxAuQ4QG0BugwYUOzZyPHJTEUrZOuqvq4z8FxtZoBsUIkTppRmGzy4eNc AcUB8HTx3a7IOIuw6DKfxGD1lNDBBDnBJV6GF0U7vKieP5rrTvqad41ycewnoFwpZktl /hxOhLLqySNtYZgMUdO+kAT7DyTv3V4sl9J3Jqhw33GoiG2KbLWvIMlVUu1af4PtFzLi 1D6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751480927; x=1752085727; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=46MgjvV3epJBZdXixG7o02s3aaxSYe96C/POTn0IK/4=; b=DKT5lrgt7y011OCqFcC9RlMLZZoZ8X8ai3ZxAJrb64CQrLI3VakWnjbcWrtltpIDBt REf0LTYi7T+1MEVIQmIdJyoxXdX+icDqMkVgH+13keZfLP/pmO6XjYHMMAsXp7fqZdeP s9xB9i3KHzrtP29JmdHH73HsXT+X5S9aQ9rLSvZR6AM5yPH02wiYZcdVPu04PloSIX48 KynZ7y6dmxG4TDfW/AHRfHZR3plSggtBZJCwvI6A1SELSUEw3S5v6t4IhvHhd68GCQSq l/hUROeh+bzOy5NP8cj8Pht6apzFsaWwRE9lPMR2Affg55f7IURgGZGYQSSI3+SeWZ3E XItQ== X-Forwarded-Encrypted: i=1; AJvYcCUDlwuddgMRSddL+vXLEQXdmnh1YAL1LyEB7o84oVYlWjRQp3Zou2gh6NctvXhTc8iPVX4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0cZA8BuDS4CmChtttVRzSbFGJfEWVbThwQ9sIXSLvrbkHdu8q q9Bj7fGl0wfjwU6ZYt66md2hubUQtHXlmSpFn92HBY/oxqIxKLi4O0Oc+j6+tzmQa7g= X-Gm-Gg: ASbGncsEhv62Um4iPu8CsNG5CHDLXAHnl1JZceBFfMjP2X2QyMXO6omwHa4pKtVH5t7 hYnLrxnvUgblwhZZSUv8nzuv3SjJwOG03xBPyZgKB6fIyhYR3sD6jbu6Th2pIUKpYmk6Y9vtD9y xAuXediLqKXb9U7cDG2ggD98LER9+TZ6REjGbxN1owBubZXDbYgbo3ksPUIcd39rw+2FTCsblRT wo80qcqk6xglSdSOqVOHWIiiStx5J41xAcIdVZ5DalJy8kIc1sL6W/PmzoGVgimMRZum/QBF0fe qdV9YnmWd+EA2lRQvvfBdgg8iG7fLqUmrN63 X-Google-Smtp-Source: AGHT+IF4ph0eWwg5euxsmabv0EeGQqiK9nx2/cAAJmk4J0EcaWCQHAieQ9iQbzhIPW0jSUPpbcOaPg== X-Received: by 2002:a05:6a00:855:b0:748:eb38:8830 with SMTP id d2e1a72fcca58-74ca0c2788emr646222b3a.13.1751480927563; Wed, 02 Jul 2025 11:28:47 -0700 (PDT) Received: from ziepe.ca ([130.41.10.202]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74af57ef308sm14319981b3a.157.2025.07.02.11.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jul 2025 11:28:46 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1uX2CK-000000051mO-3Dtn; Wed, 02 Jul 2025 15:28:44 -0300 Date: Wed, 2 Jul 2025 15:28:44 -0300 From: Jason Gunthorpe To: lizhe.67@bytedance.com Cc: alex.williamson@redhat.com, david@redhat.com, peterx@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] vfio/type1: optimize vfio_unpin_pages_remote() for large folio Message-ID: <20250702182844.GE904431@ziepe.ca> References: <20250630072518.31846-1-lizhe.67@bytedance.com> <20250630072518.31846-5-lizhe.67@bytedance.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250630072518.31846-5-lizhe.67@bytedance.com> On Mon, Jun 30, 2025 at 03:25:18PM +0800, lizhe.67@bytedance.com wrote: > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index a02bc340c112..7cacfb2cefe3 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -802,17 +802,29 @@ static long vfio_pin_pages_remote(struct vfio_dma *dma, unsigned long vaddr, > return pinned; > } > > +static inline void put_valid_unreserved_pfns(unsigned long start_pfn, > + unsigned long npage, int prot) > +{ > + unpin_user_page_range_dirty_lock(pfn_to_page(start_pfn), npage, > + prot & IOMMU_WRITE); > +} I don't think you need this wrapper. This patch and the prior look OK Jason