From: Chuck Lever <cel@kernel.org>
To: NeilBrown <neil@brown.name>, Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: <linux-nfs@vger.kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [RFC PATCH 0/2] Relocate fh_getattr()
Date: Wed, 2 Jul 2025 19:33:43 -0400 [thread overview]
Message-ID: <20250702233345.1128154-1-cel@kernel.org> (raw)
From: Chuck Lever <chuck.lever@oracle.com>
Tucked away in Mike's LOCALIO branch is a patch that, among other
changes, moves fh_getattr() to fs/nfsd/vfs.c. My feeling is that
either:
- fh_getattr() remains as part of the NFSD FH API, thus it belongs
in fs/nfsd/nfsfh.c; or
- if it is to be relocated to fs/nfsd/vfs.c, then it should adopt
the naming convention used for the public functions in that
source file.
This patch series tries on the first approach, for size.
It's a nit, I know.
Chuck Lever (2):
NFSD: Relocate the fh_want_write() and fh_drop_write() helpers
NFSD: Move the fh_getattr() helper
fs/nfsd/nfsfh.c | 23 +++++++++++++++++++++++
fs/nfsd/nfsfh.h | 38 ++++++++++++++++++++++++++++++++++++++
fs/nfsd/vfs.h | 33 ---------------------------------
3 files changed, 61 insertions(+), 33 deletions(-)
--
2.50.0
next reply other threads:[~2025-07-02 23:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 23:33 Chuck Lever [this message]
2025-07-02 23:33 ` [RFC PATCH 1/2] NFSD: Relocate the fh_want_write() and fh_drop_write() helpers Chuck Lever
2025-07-02 23:33 ` [RFC PATCH 2/2] NFSD: Move the fh_getattr() helper Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250702233345.1128154-1-cel@kernel.org \
--to=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.