From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 197F6C77B7C for ; Thu, 3 Jul 2025 00:23:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 86CFC10E7B7; Thu, 3 Jul 2025 00:23:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linux.org.uk header.i=@linux.org.uk header.b="hIEWK/+q"; dkim-atps=neutral Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A63210E7B7 for ; Thu, 3 Jul 2025 00:23:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UE4IuECEi/dNUyNkAelmVq4GoVMmkCTkbXavgIxugZY=; b=hIEWK/+qaY/gaEqVxuBP6PWJse clAunf2na3M2xH/IOanJzhSVXpfE6iRUa4UHDXJyDISe2t7wG7AWVHJ2lDYVjMVGElVv+Ej0X9Z1b FDwM25TeumuNVQvS24SK2QM/gfAXGwYzxED+ciXcavRko+kNTS+32XWtOA6NuP4tmwDa5JHeMl42a SO1nOkC0JP78bTrnUqojUdd0f5UqTnH71o6OQUQv/0q8P4Gl0aXcFbvmfSpwXM4eObZToNdadG2Cy l4V90bExKJU0AfseA/P9npO7a6nlb8EElDYidHRJxNO9EvzpyivqgPKZVkcoDm913iE88WPwFzVqQ svTSeYNQ==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uX7jd-0000000Fbrb-0iSG; Thu, 03 Jul 2025 00:23:29 +0000 Date: Thu, 3 Jul 2025 01:23:29 +0100 From: Al Viro To: Jens Axboe Cc: Greg Kroah-Hartman , linux-fsdevel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: (subset) [PATCH 01/11] zynqmp: don't bother with debugfs_file_{get,put}() in proxied fops Message-ID: <20250703002329.GF1880847@ZenIV> References: <20250702211305.GE1880847@ZenIV> <20250702211408.GA3406663@ZenIV> <175149835231.467027.7368105747282893229.b4-ty@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <175149835231.467027.7368105747282893229.b4-ty@kernel.dk> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Jul 02, 2025 at 05:19:12PM -0600, Jens Axboe wrote: > > On Wed, 02 Jul 2025 22:14:08 +0100, Al Viro wrote: > > When debugfs file has been created by debugfs_create_file_unsafe(), > > we do need the file_operations methods to use debugfs_file_{get,put}() > > to prevent concurrent removal; for files created by debugfs_create_file() > > that is done in the wrappers that call underlying methods, so there's > > no point whatsoever duplicating that in the underlying methods themselves. > > > > > > [...] > > Applied, thanks! > > [10/11] blk-mq-debugfs: use debugfs_get_aux() > commit: c25885fc939f29200cccb58ffdb920a91ec62647 Umm... That sucker depends upon the previous commit - you'll need to cast debugfs_get_aux() result to void * without that...