Re: [RFC PATCH 1/2] samples/damon: convert node id to physical address

[SeongJae Park <sj@kernel.org>]

On Thu,  3 Jul 2025 14:18:33 +0900 Yunjeong Mun <yunjeong.mun@sk.com> wrote:

> Hi Seongjae, thanks for your review :)

My pleasure! :)

> 
> On Tue,  1 Jul 2025 16:54:07 -0700 SeongJae Park <sj@kernel.org> wrote:
> > Hi Yunjeong,
> > 
> > On Tue,  1 Jul 2025 17:54:16 +0900 Yunjeong Mun <yunjeong.mun@sk.com> wrote:
> > 
> > > This patch removes the `node#_start_addr` and `node#_end_addr` knobs,
> > > and introduces logic for converting numa node id to physical address.
> > > It only checks whether a numa node is online and calculates the
> > > start and end addresses of the node. It does not verify whether each
> > > memory block within the numa node is `usable` or part of `System RAM`,
> > > as performed by `damo` [1],[2].
> > 
> > This is just a sample module, but I'd like to avoid making unnecessary
> > user-breaking changes.  How about keeping the existing knobs but adding yet
> > another knob for the automatic detection, say, 'detect_node_addresses'?
> > 
> 
> I agree. From my understanding, 'detect_node_addresses' can be set to 
> either 'Y' or 'N'. If it is set to 'Y', mtier converts node0 and node1
> to their physical addresses internally. If it is set to 'N', it uses
> the existing knobs. Is that correct? 

Yes, you're correctly understanding my suggestion.

[...]
> Thanks for your detailed reviw! Next time, I will make sure to check 
> checkpatch.pl:)

Looking forward to your next patches!  Fyi, I use 'hkml patch format', which
automatically runs[1] checkpatch.pl and misc checks for common mistakes.

[1] https://github.com/sjp38/hackermail/blob/master/USAGE.md#checker-run


Thanks,
SJ

[...]