All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] virtio: Fixes for TX ring sizing and resize error reporting
Date: Thu, 3 Jul 2025 05:30:33 -0400	[thread overview]
Message-ID: <20250703052907-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <770fc206-70e4-4c63-b438-153b57144f23@redhat.com>

On Thu, Jul 03, 2025 at 09:43:46AM +0200, Laurent Vivier wrote:
> On 28/05/2025 09:20, Michael S. Tsirkin wrote:
> > On Wed, May 28, 2025 at 08:24:32AM +0200, Paolo Abeni wrote:
> > > On 5/21/25 11:22 AM, Laurent Vivier wrote:
> > > > This patch series contains two fixes and a cleanup for the virtio subsystem.
> > > > 
> > > > The first patch fixes an error reporting bug in virtio_ring's
> > > > virtqueue_resize() function. Previously, errors from internal resize
> > > > helpers could be masked if the subsequent re-enabling of the virtqueue
> > > > succeeded. This patch restores the correct error propagation, ensuring that
> > > > callers of virtqueue_resize() are properly informed of underlying resize
> > > > failures.
> > > > 
> > > > The second patch does a cleanup of the use of '2+MAX_SKB_FRAGS'
> > > > 
> > > > The third patch addresses a reliability issue in virtio_net where the TX
> > > > ring size could be configured too small, potentially leading to
> > > > persistently stopped queues and degraded performance. It enforces a
> > > > minimum TX ring size to ensure there's always enough space for at least one
> > > > maximally-fragmented packet plus an additional slot.
> > > 
> > > @Michael: it's not clear to me if you prefer take this series via your
> > > tree or if it should go via net. Please LMK, thanks!
> > > 
> > > Paolo
> > 
> > Given 1/3 is in virtio I was going to take it. Just after rc1,
> > though.
> > 
> 
> Michael, if you don't have time to merge this series, perhaps Paolo can?
> 
> Thanks,
> Laurent


Sorry I forgot I asked that netdev guys don't handle it.

-- 
MST


  reply	other threads:[~2025-07-03  9:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-21  9:22 [PATCH v2 0/3] virtio: Fixes for TX ring sizing and resize error reporting Laurent Vivier
2025-05-21  9:22 ` [PATCH v2 1/3] virtio_ring: Fix error reporting in virtqueue_resize Laurent Vivier
2025-05-22  1:56   ` Jason Wang
2025-05-21  9:22 ` [PATCH v2 2/3] virtio_net: Cleanup '2+MAX_SKB_FRAGS' Laurent Vivier
2025-05-21  9:33   ` Xuan Zhuo
2025-05-22  1:56   ` Jason Wang
2025-05-21  9:22 ` [PATCH v2 3/3] virtio_net: Enforce minimum TX ring size for reliability Laurent Vivier
2025-05-21  9:34   ` Xuan Zhuo
2025-05-22  1:56   ` Jason Wang
2025-05-27  7:32 ` [PATCH v2 0/3] virtio: Fixes for TX ring sizing and resize error reporting Lei Yang
2025-05-28  6:24 ` Paolo Abeni
2025-05-28  7:20   ` Michael S. Tsirkin
2025-06-16 13:07     ` Laurent Vivier
2025-06-23  8:23       ` Laurent Vivier
2025-07-03  7:43     ` Laurent Vivier
2025-07-03  9:30       ` Michael S. Tsirkin [this message]
2025-07-03  9:31   ` Michael S. Tsirkin
2025-07-03  9:34     ` Paolo Abeni
2025-07-08  0:29       ` Jakub Kicinski
2025-07-08 16:03         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250703052907-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.