All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Lin via Grub-devel <grub-devel@gnu.org>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Gary Lin <glin@suse.com>, Daniel Kiper <daniel.kiper@oracle.com>,
	Daniel Axtens <dja@axtens.net>,
	Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
Subject: [PATCH] dl: fix grub_dl_is_persistent() for EMU
Date: Thu,  3 Jul 2025 14:09:41 +0800	[thread overview]
Message-ID: <20250703060941.14883-1-glin@suse.com> (raw)

When attempting to build grub-emu, the compilation failed with the
following error message:

include/grub/dl.h: In function ‘grub_dl_is_persistent’:
include/grub/dl.h:262:1: error: no return statement in function returning non-void [-Werror=return-type]

To avoid the erorr, make the function always return 0.

Fixes: ba8eadde6be1 (dl: Provide a fake grub_dl_set_persistent() and grub_dl_is_persistent() for the emu target)

Signed-off-by: Gary Lin <glin@suse.com>
Cc: Daniel Axtens <dja@axtens.net>
Cc: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
---
 include/grub/dl.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/grub/dl.h b/include/grub/dl.h
index b8135c8f3..53bf9abdb 100644
--- a/include/grub/dl.h
+++ b/include/grub/dl.h
@@ -259,6 +259,7 @@ grub_dl_set_persistent (grub_dl_t mod __attribute__((unused)))
 static inline int
 grub_dl_is_persistent (grub_dl_t mod __attribute__((unused)))
 {
+  return 0;
 }
 #else
 static inline void
-- 
2.43.0


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

             reply	other threads:[~2025-07-03  6:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03  6:09 Gary Lin via Grub-devel [this message]
2025-07-03  7:11 ` [PATCH] dl: fix grub_dl_is_persistent() for EMU Sudhakar Kuppusamy
2025-07-04 13:53   ` Daniel Kiper via Grub-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250703060941.14883-1-glin@suse.com \
    --to=grub-devel@gnu.org \
    --cc=daniel.kiper@oracle.com \
    --cc=dja@axtens.net \
    --cc=glin@suse.com \
    --cc=sudhakar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.