From: Christoph Hellwig <hch@lst.de>
To: Kamaljit Singh <kamaljit.singh1@wdc.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
cassel@kernel.org, dlemoal@kernel.org
Subject: Re: [PATCH v2 2/3] nvme: prevent admin controller from smart log fetch (LID 2)
Date: Thu, 3 Jul 2025 11:05:33 +0200 [thread overview]
Message-ID: <20250703090533.GC4757@lst.de> (raw)
In-Reply-To: <20250702005830.889217-3-kamaljit.singh1@wdc.com>
On Tue, Jul 01, 2025 at 05:58:28PM -0700, Kamaljit Singh wrote:
> Similar to a discovery ctrl, prevent an admin-ctrl from getting a smart
> log. LID 2 is optional for admin controllers to support.
>
> In the future when support for the newly added LID=0 (supported log
> pages) is added, GLP accesses can be made smarter by basing such calls
> on response from LID=0 reads.
Let's leave this in. Failing a get_log page is fine. The difference
for discovery controllers is that implementing it is prohibited.
next prev parent reply other threads:[~2025-07-03 9:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 0:58 [PATCH v2 0/3] Support for Administrative Controllers Kamaljit Singh
2025-07-02 0:58 ` [PATCH v2 1/3] nvme: add capability to connect to an admin controller Kamaljit Singh
2025-07-02 2:11 ` Damien Le Moal
2025-07-02 18:39 ` Kamaljit Singh
2025-07-03 9:04 ` hch
2025-07-03 8:55 ` Hannes Reinecke
2025-07-16 21:27 ` Kamaljit Singh
2025-07-02 0:58 ` [PATCH v2 2/3] nvme: prevent admin controller from smart log fetch (LID 2) Kamaljit Singh
2025-07-02 2:13 ` Damien Le Moal
2025-07-02 18:21 ` Kamaljit Singh
2025-07-03 8:56 ` Hannes Reinecke
2025-07-03 9:05 ` Christoph Hellwig [this message]
2025-07-02 0:58 ` [PATCH v2 3/3] nvme: prevent ioq creation for discovery controllers Kamaljit Singh
2025-07-02 2:18 ` Damien Le Moal
2025-07-02 18:09 ` Kamaljit Singh
2025-07-02 23:59 ` Damien Le Moal
2025-07-03 9:05 ` hch
2025-07-03 9:42 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250703090533.GC4757@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=kamaljit.singh1@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.