From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2090A1C5D46; Thu, 3 Jul 2025 14:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751554045; cv=none; b=PtVekElOK0mvOBzUdDLb7zOjuglB/pPZBsRt/LxxPIYA4GTRTHnDimbAumNsfTxyrDE9vDHw5iXly4iCGP9nWl3//nlC4O2Abv/Kle9XMPqL6F1ZUkdxh2oVexG4q8PUYTr/zLBlrtxHilj1ftSQ8MxnZIuzkwAbL1mDfq6+QhY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751554045; c=relaxed/simple; bh=aI5TN+yeF5Hw0oue197arOiTq/D/GvleE0qTHUqUHYw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pyfZIvPXNsdXqcC2zE1JS724rtkPRznaE7+UW2KdQ2EUcMfbHLPcpot4D/c1CtHuISryp+d2e6Oz9C9rvay9Vv17en4L1atXl2/KgyIDj0J45mCdyqLMb4h0aTkDvj1EGNA9VDGJXbHhuKvA04epHSIRqqoncpffT+MM6jBR7+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fZQOERlM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fZQOERlM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B981C4CEE3; Thu, 3 Jul 2025 14:47:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751554045; bh=aI5TN+yeF5Hw0oue197arOiTq/D/GvleE0qTHUqUHYw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fZQOERlMaKVzSCrYO7gAwyLOd1c2mqOdR4/3xhlBpJjrTdI9L5MJ25kZUfDhuBdSB 80C8auwIRTcZH2xY4fmnXVNw+JLfqmkrvKTAzBRil/EuDKZ4R6wijgy1mCmTBH9exi w1SwPNjza4YWQc51dYVoIelNzzYSxkpTAoqhIX4s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Lin.Cao" , Philipp Stanner , =?UTF-8?q?Christian=20K=C3=B6nig?= , Sasha Levin Subject: [PATCH 6.12 032/218] drm/scheduler: signal scheduled fence when kill job Date: Thu, 3 Jul 2025 16:39:40 +0200 Message-ID: <20250703143957.239556130@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250703143955.956569535@linuxfoundation.org> References: <20250703143955.956569535@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lin.Cao [ Upstream commit 471db2c2d4f80ee94225a1ef246e4f5011733e50 ] When an entity from application B is killed, drm_sched_entity_kill() removes all jobs belonging to that entity through drm_sched_entity_kill_jobs_work(). If application A's job depends on a scheduled fence from application B's job, and that fence is not properly signaled during the killing process, application A's dependency cannot be cleared. This leads to application A hanging indefinitely while waiting for a dependency that will never be resolved. Fix this issue by ensuring that scheduled fences are properly signaled when an entity is killed, allowing dependent applications to continue execution. Signed-off-by: Lin.Cao Reviewed-by: Philipp Stanner Signed-off-by: Christian König Link: https://lore.kernel.org/r/20250515020713.1110476-1-lincao12@amd.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/scheduler/sched_entity.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c index 002057be0d84a..c9c50e3b18a23 100644 --- a/drivers/gpu/drm/scheduler/sched_entity.c +++ b/drivers/gpu/drm/scheduler/sched_entity.c @@ -189,6 +189,7 @@ static void drm_sched_entity_kill_jobs_work(struct work_struct *wrk) { struct drm_sched_job *job = container_of(wrk, typeof(*job), work); + drm_sched_fence_scheduled(job->s_fence, NULL); drm_sched_fence_finished(job->s_fence, -ESRCH); WARN_ON(job->s_fence->parent); job->sched->ops->free_job(job); -- 2.39.5