From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29C112EF67A; Thu, 3 Jul 2025 14:50:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751554227; cv=none; b=D8kDmqMMfSVS+TuEsozShNw1d262Mg9wiDfRxmcXgN7+QdDIrWdopI8sc6XEjZfalMWkqxlDDLs5cKjkl+2BMcrjRna8CrUD5+dl8JWdPe/2sxOK3uw9e/zPmnKmWoyG5m9gyCq1MsVeFbGPpetPSMUD6OQkaoCwwK9ARO+J/0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751554227; c=relaxed/simple; bh=q/mFpIB2cNK5yPSWDWgiGNzjB5y6/D8KRtW/4+v05Fs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hHp1zUQzzYvCFzwyw7uRpSeloxVUzALyGtd0mdiim8Zf1qX9kibabV4W7Jrz7wJkYzIgJV8E+BTaxoqePxqu1hdAKbCev1EqLCpgHdORVNXBt4Iy4dcKbrNgGZ+EozZSzn/XfDgf8PxxZT4eaivnsL24sj7O0M16w08IhPYzg9Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NmKVoVLo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NmKVoVLo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A52DC4CEED; Thu, 3 Jul 2025 14:50:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751554226; bh=q/mFpIB2cNK5yPSWDWgiGNzjB5y6/D8KRtW/4+v05Fs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NmKVoVLoFc0kkZOADL3B51vkZUoPme3+9xuXjk4JjMHUCj58VSzPm/oIHF5PnO4FG ZlvAmjphHkWDpQMRG6WAlPa+0h26i7deKvIlRKx6AIOJiysNgLzkzRld6JkhQlqx1h wDuYpUrzQr3HO78r3q+V7ItPLJSQeAgAhM/6SOTA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Youngjun Lee , Takashi Iwai , Sasha Levin Subject: [PATCH 6.12 093/218] ALSA: usb-audio: Fix out-of-bounds read in snd_usb_get_audioformat_uac3() Date: Thu, 3 Jul 2025 16:40:41 +0200 Message-ID: <20250703143959.655189731@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250703143955.956569535@linuxfoundation.org> References: <20250703143955.956569535@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Youngjun Lee [ Upstream commit fb4e2a6e8f28a3c0ad382e363aeb9cd822007b8a ] In snd_usb_get_audioformat_uac3(), the length value returned from snd_usb_ctl_msg() is used directly for memory allocation without validation. This length is controlled by the USB device. The allocated buffer is cast to a uac3_cluster_header_descriptor and its fields are accessed without verifying that the buffer is large enough. If the device returns a smaller than expected length, this leads to an out-of-bounds read. Add a length check to ensure the buffer is large enough for uac3_cluster_header_descriptor. Signed-off-by: Youngjun Lee Fixes: 9a2fe9b801f5 ("ALSA: usb: initial USB Audio Device Class 3.0 support") Link: https://patch.msgid.link/20250623-uac3-oob-fix-v1-1-527303eaf40a@samsung.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/usb/stream.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/usb/stream.c b/sound/usb/stream.c index c1ea8844a46fc..aa91d63749f2c 100644 --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -987,6 +987,8 @@ snd_usb_get_audioformat_uac3(struct snd_usb_audio *chip, * and request Cluster Descriptor */ wLength = le16_to_cpu(hc_header.wLength); + if (wLength < sizeof(cluster)) + return NULL; cluster = kzalloc(wLength, GFP_KERNEL); if (!cluster) return ERR_PTR(-ENOMEM); -- 2.39.5