From: Rob Herring <robh@kernel.org>
To: Mao Jinlong <quic_jinlmao@quicinc.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@arm.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v8 1/2] dt-bindings: arm: Add label in the coresight components
Date: Thu, 3 Jul 2025 10:43:26 -0500 [thread overview]
Message-ID: <20250703154326.GA1674898-robh@kernel.org> (raw)
In-Reply-To: <20250703130453.4265-2-quic_jinlmao@quicinc.com>
On Thu, Jul 03, 2025 at 09:04:52PM +0800, Mao Jinlong wrote:
> Current name of coresight component's folder consists of prefix of
> the device and the id in the device list. When run 'ls' command,
> we can get the register address of the device. Take CTI for example,
> if we want to set the config for modem CTI, but we can't know which
> CTI is modem CTI from all current information.
>
> cti_sys0 -> ../../../devices/platform/soc@0/138f0000.cti/cti_sys0
> cti_sys1 -> ../../../devices/platform/soc@0/13900000.cti/cti_sys1
>
> Add label to show hardware context information of each coresight
> device. There will be a sysfs node label in each device folder.
>
> cat /sys/bus/coresight/devices/cti_sys0/label
>
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Mike Leach <mike.leach@linaro.org>
> ---
> .../devicetree/bindings/arm/arm,coresight-cti.yaml | 6 ++++++
> .../devicetree/bindings/arm/arm,coresight-dummy-sink.yaml | 6 ++++++
> .../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 6 ++++++
> .../bindings/arm/arm,coresight-dynamic-funnel.yaml | 6 ++++++
> .../bindings/arm/arm,coresight-dynamic-replicator.yaml | 6 ++++++
> .../bindings/arm/arm,coresight-static-funnel.yaml | 6 ++++++
> .../bindings/arm/arm,coresight-static-replicator.yaml | 6 ++++++
> .../devicetree/bindings/arm/arm,coresight-tmc.yaml | 6 ++++++
> .../devicetree/bindings/arm/qcom,coresight-tpda.yaml | 6 ++++++
> .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 6 ++++++
> 10 files changed, 60 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
> index 2d5545a2b49c..5ca6d3d313a3 100644
> --- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
> @@ -98,6 +98,12 @@ properties:
> power-domains:
> maxItems: 1
>
> + label:
> + $ref: /schemas/types.yaml#/definitions/string
label already has a type. Drop.
> + description:
> + Define the label which can describe what kind of HW or system the
> + coresight device belongs to.
'compatible' tells us 'what kind of HW'.
> +
> arm,cti-ctm-id:
> $ref: /schemas/types.yaml#/definitions/uint32
> description:
next prev parent reply other threads:[~2025-07-03 20:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 13:04 [PATCH v8 0/2] coresight: Add label sysfs node support Mao Jinlong
2025-07-03 13:04 ` [PATCH v8 1/2] dt-bindings: arm: Add label in the coresight components Mao Jinlong
2025-07-03 15:43 ` Rob Herring [this message]
2025-07-03 13:04 ` [PATCH v8 2/2] coresight: Add label sysfs node support Mao Jinlong
2025-07-03 14:19 ` Leo Yan
2025-07-16 2:42 ` Jinlong Mao
2025-07-16 10:45 ` Mike Leach
2025-07-17 3:03 ` Jinlong Mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250703154326.GA1674898-robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@arm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_jinlmao@quicinc.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.