All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Dexuan Cui <decui@microsoft.com>
Cc: Stable <stable@vger.kernel.org>, Long Li <longli@microsoft.com>
Subject: Re: [EXTERNAL] Re: Please cherry-pick this commit to v5.15.y, 5.10.y and 5.4.y: 23e118a48acf ("PCI: hv: Do not set PCI_COMMAND_MEMORY to reduce VM boot time")
Date: Thu, 3 Jul 2025 07:14:04 +0200	[thread overview]
Message-ID: <2025070345-viral-never-921c@gregkh> (raw)
In-Reply-To: <BL1PR21MB311511454704263AF04C53B8BF43A@BL1PR21MB3115.namprd21.prod.outlook.com>

On Thu, Jul 03, 2025 at 01:15:47AM +0000, Dexuan Cui wrote:
> 
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Sent: Wednesday, July 2, 2025 1:08 AM
> > To: Dexuan Cui <decui@microsoft.com>
> > Cc: Stable <stable@vger.kernel.org>; Long Li <longli@microsoft.com>
> > Subject: [EXTERNAL] Re: Please cherry-pick this commit to v5.15.y, 5.10.y and
> > 5.4.y: 23e118a48acf ("PCI: hv: Do not set PCI_COMMAND_MEMORY to
> > reduce VM boot time")
> > 
> > On Wed, Jun 25, 2025 at 06:05:26AM +0000, Dexuan Cui wrote:
> > > Hi,
> > > The commit has been in v6.1.y for 3+ years (but not in the 5.x stable
> > > branches):
> > >         23e118a48acf ("PCI: hv: Do not set PCI_COMMAND_MEMORY to
> > > reduce VM boot time")
> > >
> > > The commit can be cherry-picked cleanly to the latest 5.x stable branches,
> > > i.e. 5.15.185, 5.10.238 and 5.4.294.
> > 
> > It adds a new build warning on 5.4.y, so I will not apply it there,
> > sorry.  Will go apply it to 5.10.y and 5.15.y for now.
> 
> Out of curiosity, I built 5.4.y plus the commit and got this warning:
> 
> drivers/pci/controller//pci-hyperv.c: In function 'prepopulate_bars':
> drivers/pci/controller//pci-hyperv.c:1731:13: warning: unused variable 'command' [-Wunused-variable]
> 
> I think 5.4.y lacks another commit made in 2019:
> ac82fc832708 ("PCI: hv: Add hibernation support")
> but definitely we don't want to pull this commit into 5.4.y.
> 
> > thanks,
> > 
> > greg k-h
> 
> I guess this requested commit doesn't really need to go into 5.4.y,
> which I suppose isn't used widely any more. I listed it just for
> completeness :-)

If you really want it in 5.4.y, please provide a version that doesn't
add the warning :)


  reply	other threads:[~2025-07-03  5:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-25  6:05 Please cherry-pick this commit to v5.15.y, 5.10.y and 5.4.y: 23e118a48acf ("PCI: hv: Do not set PCI_COMMAND_MEMORY to reduce VM boot time") Dexuan Cui
2025-07-02  8:08 ` Greg KH
2025-07-03  1:15   ` [EXTERNAL] " Dexuan Cui
2025-07-03  5:14     ` Greg KH [this message]
2025-07-03  5:25       ` Dexuan Cui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025070345-viral-never-921c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=decui@microsoft.com \
    --cc=longli@microsoft.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.