From: Simon Horman <horms@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
"Andrew Lunn" <andrew@lunn.ch>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Shuah Khan" <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] selftests: ethtool: Introduce ethernet PHY selftests on netdevsim
Date: Fri, 4 Jul 2025 14:20:19 +0100 [thread overview]
Message-ID: <20250704132019.GM41770@horms.kernel.org> (raw)
In-Reply-To: <20250702082806.706973-4-maxime.chevallier@bootlin.com>
On Wed, Jul 02, 2025 at 10:28:05AM +0200, Maxime Chevallier wrote:
> Now that netdevsim supports PHY device simulation, we can start writing
> some tests to cover a little bit all PHY-related ethtool commands.
>
> So far we only test the basic use of "ethtool --show-phys", with :
> - A simple command to get a PHY we just added
> - A DUMP command listing PHYs on multiple netdevsim instances
> - A Filtered DUMP command listing all PHYs on a netdevsim
>
> Introduce some helpers to create netdevsim PHYs, and a new test file.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Hi Maxime,
We have recently started running shellcheck as part of our CI (NIPA).
Could you do so for the scripts added and modified by this patch?
> ---
> .../selftests/drivers/net/netdevsim/config | 1 +
> .../drivers/net/netdevsim/ethtool-common.sh | 15 +++++
> .../drivers/net/netdevsim/ethtool-phy.sh | 64 +++++++++++++++++++
Should ethtool-phy.sh be added to TEST_PROGS the Makefile in
the same directory?
...
next prev parent reply other threads:[~2025-07-04 13:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 8:28 [PATCH net-next 0/3] netdevsim: add support for PHY devices Maxime Chevallier
2025-07-02 8:28 ` [PATCH net-next 1/3] net: netdevsim: Add PHY support in netdevsim Maxime Chevallier
2025-07-04 12:17 ` kernel test robot
2025-07-04 12:43 ` Simon Horman
2025-07-04 12:46 ` Maxime Chevallier
2025-07-08 14:01 ` Andrew Lunn
2025-07-08 14:13 ` Maxime Chevallier
2025-07-02 8:28 ` [PATCH net-next 2/3] selftests: ethtool: Drop the unused old_netdevs variable Maxime Chevallier
2025-07-07 15:22 ` Vladimir Oltean
2025-07-02 8:28 ` [PATCH net-next 3/3] selftests: ethtool: Introduce ethernet PHY selftests on netdevsim Maxime Chevallier
2025-07-04 13:20 ` Simon Horman [this message]
2025-07-04 13:32 ` Maxime Chevallier
2025-07-04 16:50 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250704132019.GM41770@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.