From: Simon Horman <horms@kernel.org>
To: Wang Liang <wangliang74@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, alex.aring@gmail.com, dsahern@kernel.org,
yuehaibing@huawei.com, zhangchangzhong@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: replace ND_PRINTK with dynamic debug
Date: Fri, 4 Jul 2025 15:19:04 +0100 [thread overview]
Message-ID: <20250704141904.GV41770@horms.kernel.org> (raw)
In-Reply-To: <20250701081114.1378895-1-wangliang74@huawei.com>
On Tue, Jul 01, 2025 at 04:11:14PM +0800, Wang Liang wrote:
> ND_PRINTK with val > 1 only works when the ND_DEBUG was set in compilation
> phase. Replace it with dynamic debug. Convert ND_PRINTK with val <= 1 to
> net_{err,warn}_ratelimited, and convert the rest to net_dbg_ratelimited.
>
> Suggested-by: Ido Schimmel <idosch@idosch.org>
> Signed-off-by: Wang Liang <wangliang74@huawei.com>
> ---
> Changes in v2:
> Use dynamic debug instead of sysctl.
Thanks, I agree this addresses Ido's review of v1.
And, moreover, is a good approach the problem at hand.
next prev parent reply other threads:[~2025-07-04 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 8:11 [PATCH net-next v2] net: replace ND_PRINTK with dynamic debug Wang Liang
2025-07-04 14:19 ` Simon Horman [this message]
2025-07-04 16:10 ` Ido Schimmel
2025-07-04 16:46 ` Simon Horman
2025-07-05 1:38 ` Wang Liang
2025-07-05 6:38 ` Wang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250704141904.GV41770@horms.kernel.org \
--to=horms@kernel.org \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wangliang74@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.