From: Simon Horman <horms@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, shenjian15@huawei.com,
liuyonglong@huawei.com, chenhao418@huawei.com,
jonathan.cameron@huawei.com,
shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/4] net: hns3: fix concurrent setting vlan filter issue
Date: Fri, 4 Jul 2025 16:52:16 +0100 [thread overview]
Message-ID: <20250704155216.GF41770@horms.kernel.org> (raw)
In-Reply-To: <20250702130901.2879031-2-shaojijie@huawei.com>
On Wed, Jul 02, 2025 at 09:08:58PM +0800, Jijie Shao wrote:
> From: Jian Shen <shenjian15@huawei.com>
>
> The vport->req_vlan_fltr_en may be changed concurrently by function
> hclge_sync_vlan_fltr_state() called in periodic work task and
> function hclge_enable_vport_vlan_filter() called by user configuration.
> It may cause the user configuration inoperative. Fixes it by protect
> the vport->req_vlan_fltr by vport_lock.
>
> Fixes: fa6a262a2550 ("net: hns3: add support for VF modify VLAN filter state")
I think the commit sited above is for the VF driver, whereas this
patch addresses PF driver code. I think the following is the
correct tag:
Fixes: 2ba306627f59 ("net: hns3: add support for modify VLAN filter state")
> Signed-off-by: Jian Shen <shenjian15@huawei.com>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Otherwise, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-07-04 15:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 13:08 [PATCH net 0/4] There are some bugfix for the HNS3 ethernet driver Jijie Shao
2025-07-02 13:08 ` [PATCH net 1/4] net: hns3: fix concurrent setting vlan filter issue Jijie Shao
2025-07-04 15:52 ` Simon Horman [this message]
2025-07-08 9:30 ` Jijie Shao
2025-07-02 13:08 ` [PATCH net 2/4] net: hns3: disable interrupt when ptp init failed Jijie Shao
2025-07-04 15:55 ` Simon Horman
2025-07-02 13:09 ` [PATCH net 3/4] net: hns3: fixed vf get max channels bug Jijie Shao
2025-07-04 16:05 ` Simon Horman
2025-07-05 7:24 ` David Laight
2025-07-08 9:37 ` Jijie Shao
2025-07-08 16:35 ` Simon Horman
2025-07-02 13:09 ` [PATCH net 4/4] net: hns3: default enable tx bounce buffer when smmu enabled Jijie Shao
2025-07-04 16:31 ` Simon Horman
2025-07-08 9:41 ` Jijie Shao
2025-07-08 16:35 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250704155216.GF41770@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.