From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: David Jeffery <djeffery@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
Stuart Hayes <stuart.w.hayes@gmail.com>,
linux-kernel@vger.kernel.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
Martin Belanger <Martin.Belanger@dell.com>,
Oliver O'Halloran <oohall@gmail.com>,
Daniel Wagner <dwagner@suse.de>, Keith Busch <kbusch@kernel.org>,
Lukas Wunner <lukas@wunner.de>, Jeremy Allison <jallison@ciq.com>,
Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org,
Nathan Chancellor <nathan@kernel.org>,
Jan Kiszka <jan.kiszka@seimens.com>,
Bert Karwatzki <spasswolf@web.de>
Subject: Re: [PATCH v10 0/5] shut down devices asynchronously
Date: Fri, 4 Jul 2025 16:13:48 +0200 [thread overview]
Message-ID: <2025070438-apache-sprawl-0cbc@gregkh> (raw)
In-Reply-To: <CA+-xHTFKh0VUJ0r4K5L5b0dmrs9d1+cNkqf4HvKa4E-r_+u2CA@mail.gmail.com>
On Fri, Jul 04, 2025 at 10:09:01AM -0400, David Jeffery wrote:
> On Fri, Jul 4, 2025 at 9:45 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Jul 04, 2025 at 09:38:15AM -0400, David Jeffery wrote:
> > > On Thu, Jul 3, 2025 at 7:47 AM Christoph Hellwig <hch@lst.de> wrote:
> > > >
> > > > On Wed, Jun 25, 2025 at 03:18:48PM -0500, Stuart Hayes wrote:
> > > > > Address resource and timing issues when spawning a unique async thread
> > > > > for every device during shutdown:
> > > > > * Make the asynchronous threads able to shut down multiple devices,
> > > > > instead of spawning a unique thread for every device.
> > > > > * Modify core kernel async code with a custom wake function so it
> > > > > doesn't wake up threads waiting to synchronize every time the cookie
> > > > > changes
> > > >
> > > > Given all these thread spawning issues, why can't we just go back
> > > > to the approach that kicks off shutdown asynchronously and then waits
> > > > for it without spawning all these threads?
> > > >
> > >
> > > The async subsystem fix is something that should be fixed regardless
> > > of async shutdown. Async shutdown's use just exposed its thundering
> > > herd behavior which is easily fixed.
> >
> > Great, then please submit that on its own and get the maintainer of that
> > subsystem to agree and accept it as I have no way to judge that code at
> > all.
>
> Unfortunately, it does not have a maintainer listed and sees limited
> activity. Would CC-ing some of the recent developers of kernel/async.c
> to ask them to review be recommended in this situation?
Like any other piece of the kernel, yes :)
prev parent reply other threads:[~2025-07-04 14:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 20:18 [PATCH v10 0/5] shut down devices asynchronously Stuart Hayes
2025-06-25 20:18 ` [PATCH v10 1/5] kernel/async: streamline cookie synchronization Stuart Hayes
2025-07-08 22:17 ` Sultan Alsawaf
2025-06-25 20:18 ` [PATCH v10 2/5] driver core: don't always lock parent in shutdown Stuart Hayes
2025-07-01 8:50 ` Greg Kroah-Hartman
2025-07-02 14:38 ` David Jeffery
2025-06-25 20:18 ` [PATCH v10 3/5] driver core: separate function to shutdown one device Stuart Hayes
2025-06-25 20:18 ` [PATCH v10 4/5] driver core: shut down devices asynchronously Stuart Hayes
2025-06-25 20:18 ` [PATCH v10 5/5] nvme-pci: Make driver prefer asynchronous shutdown Stuart Hayes
2025-06-30 20:33 ` [PATCH v10 0/5] shut down devices asynchronously Michael Kelley
2025-06-30 22:02 ` Laurence Oberman
2025-07-03 11:46 ` Christoph Hellwig
2025-07-03 15:41 ` Jeremy Allison
2025-07-04 13:45 ` David Jeffery
2025-07-04 16:26 ` Sultan Alsawaf
2025-07-07 15:34 ` David Jeffery
2025-07-07 20:49 ` stuart hayes
2025-07-08 0:00 ` Sultan Alsawaf
2025-07-08 21:47 ` Sultan Alsawaf
2025-07-08 21:31 ` Sultan Alsawaf
2025-07-03 15:59 ` stuart hayes
2025-07-04 13:38 ` David Jeffery
2025-07-04 13:44 ` Greg Kroah-Hartman
2025-07-04 14:09 ` David Jeffery
2025-07-04 14:13 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025070438-apache-sprawl-0cbc@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Martin.Belanger@dell.com \
--cc=axboe@fb.com \
--cc=djeffery@redhat.com \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=jallison@ciq.com \
--cc=jan.kiszka@seimens.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=lukas@wunner.de \
--cc=nathan@kernel.org \
--cc=oohall@gmail.com \
--cc=rafael@kernel.org \
--cc=sagi@grimberg.me \
--cc=spasswolf@web.de \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.