From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD04518DB1E for ; Sun, 6 Jul 2025 02:03:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751767436; cv=none; b=tHcyz7KN3Xx8DCs6T75gX/3CIPW2tqIHl93YP0Bq0FcO3YpWmWdoQNjgZnSsjpnIwSW4G/9mkQ8ucG6PMBc8jg31EzbfSUMwwNvf1S8Tz1+mMhGSFF4DldR6rC0zDyiOzLrD76YMVTpBt/yjL63evZJfOlEGdvOegIJL74V9f6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751767436; c=relaxed/simple; bh=EcAoA2b/jkx343x9wASIqopgCfm4tGC2yEw42QqX/pg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tuK1q8oVUr87vISfhL/0tebsUL1xQ6biJyi4OzMlgv/5knjLpDy+ZOtn03XQQ+rde8W3PvuUK4IWfHpH0XBMo8FU5PNeKTS8asLYv65oIZ/2n5dtebZKOnkwySID2QEwiyVWX2bgPq3mhY2D4BiZVyBpMZzWmCcwD42mcWWpt04= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QK1Sh5JC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QK1Sh5JC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABCA5C4CEF2; Sun, 6 Jul 2025 02:03:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751767436; bh=EcAoA2b/jkx343x9wASIqopgCfm4tGC2yEw42QqX/pg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QK1Sh5JCFBTkCnxCrWx5BS75sfegSzAa6hiQVRT04yBje2Wbs0xDdlDUF0YN5Hbyp GdXxPwpfdop95in3VbwQ71FX6tLKYB/yHKPv9cwG7iAFcbF8QaGcgevKxoBq+6+cxC 9C7Hc/+4y9Up2GAdMxVumDAqjkFlKtdLNNW8f1f6Fz7+eD6mjaNjy+hjh49DpNIqQA zrZEx83UuuUT+AKVpZYM9sDRPR5Ldv/BFguc1gR4bf423tA4eVeONPwi5WBLTM1Cvv zqXd7HGjK+ZVSsCAtaEPVz+C4PjarHH2w0TXr5a/Jyb+J/HFN/JILGAzbnIHd9pde6 xsmkw60K/d/aQ== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Gal Pressman , Leon Romanovsky , Jiri Pirko Subject: [PATCH net-next V5 05/13] devlink: pass struct devlink_port * as arg to devlink_nl_param_fill() Date: Sat, 5 Jul 2025 19:03:25 -0700 Message-ID: <20250706020333.658492-6-saeed@kernel.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250706020333.658492-1-saeed@kernel.org> References: <20250706020333.658492-1-saeed@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jiri Pirko As the follow-up patch will need to get struct devlink_port *, avoid unnecessary lookup and instead of port_index pass the struct devlink_port * directly. Signed-off-by: Jiri Pirko Signed-off-by: Saeed Mahameed --- net/devlink/param.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/net/devlink/param.c b/net/devlink/param.c index 3a5fe0a639ea..fcb59763530a 100644 --- a/net/devlink/param.c +++ b/net/devlink/param.c @@ -227,7 +227,7 @@ devlink_nl_param_value_fill_one(struct sk_buff *msg, } static int devlink_nl_param_fill(struct sk_buff *msg, struct devlink *devlink, - unsigned int port_index, + struct devlink_port *devlink_port, struct devlink_param_item *param_item, enum devlink_command cmd, u32 portid, u32 seq, int flags) @@ -273,7 +273,8 @@ static int devlink_nl_param_fill(struct sk_buff *msg, struct devlink *devlink, if (cmd == DEVLINK_CMD_PORT_PARAM_GET || cmd == DEVLINK_CMD_PORT_PARAM_NEW || cmd == DEVLINK_CMD_PORT_PARAM_DEL) - if (nla_put_u32(msg, DEVLINK_ATTR_PORT_INDEX, port_index)) + if (nla_put_u32(msg, DEVLINK_ATTR_PORT_INDEX, + devlink_port->index)) goto genlmsg_cancel; param_attr = nla_nest_start_noflag(msg, DEVLINK_ATTR_PARAM); @@ -315,7 +316,7 @@ static int devlink_nl_param_fill(struct sk_buff *msg, struct devlink *devlink, } static void devlink_param_notify(struct devlink *devlink, - unsigned int port_index, + struct devlink_port *devlink_port, struct devlink_param_item *param_item, enum devlink_command cmd) { @@ -336,7 +337,7 @@ static void devlink_param_notify(struct devlink *devlink, msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); if (!msg) return; - err = devlink_nl_param_fill(msg, devlink, port_index, param_item, cmd, + err = devlink_nl_param_fill(msg, devlink, devlink_port, param_item, cmd, 0, 0, 0); if (err) { nlmsg_free(msg); @@ -353,7 +354,7 @@ static void devlink_params_notify(struct devlink *devlink, unsigned long param_id; xa_for_each(&devlink->params, param_id, param_item) - devlink_param_notify(devlink, 0, param_item, cmd); + devlink_param_notify(devlink, NULL, param_item, cmd); } void devlink_params_notify_register(struct devlink *devlink) @@ -377,7 +378,7 @@ static int devlink_nl_param_get_dump_one(struct sk_buff *msg, int err = 0; xa_for_each_start(&devlink->params, param_id, param_item, state->idx) { - err = devlink_nl_param_fill(msg, devlink, 0, param_item, + err = devlink_nl_param_fill(msg, devlink, NULL, param_item, DEVLINK_CMD_PARAM_GET, NETLINK_CB(cb->skb).portid, cb->nlh->nlmsg_seq, flags); @@ -483,7 +484,7 @@ int devlink_nl_param_get_doit(struct sk_buff *skb, if (!msg) return -ENOMEM; - err = devlink_nl_param_fill(msg, devlink, 0, param_item, + err = devlink_nl_param_fill(msg, devlink, NULL, param_item, DEVLINK_CMD_PARAM_GET, info->snd_portid, info->snd_seq, 0); if (err) { @@ -495,7 +496,7 @@ int devlink_nl_param_get_doit(struct sk_buff *skb, } static int __devlink_nl_cmd_param_set_doit(struct devlink *devlink, - unsigned int port_index, + struct devlink_port *devlink_port, struct xarray *params, struct genl_info *info, enum devlink_command cmd) @@ -545,7 +546,7 @@ static int __devlink_nl_cmd_param_set_doit(struct devlink *devlink, return err; } - devlink_param_notify(devlink, port_index, param_item, cmd); + devlink_param_notify(devlink, devlink_port, param_item, cmd); return 0; } @@ -553,7 +554,7 @@ int devlink_nl_param_set_doit(struct sk_buff *skb, struct genl_info *info) { struct devlink *devlink = info->user_ptr[0]; - return __devlink_nl_cmd_param_set_doit(devlink, 0, &devlink->params, + return __devlink_nl_cmd_param_set_doit(devlink, NULL, &devlink->params, info, DEVLINK_CMD_PARAM_NEW); } @@ -612,7 +613,7 @@ static int devlink_param_register(struct devlink *devlink, if (err) goto err_xa_insert; - devlink_param_notify(devlink, 0, param_item, DEVLINK_CMD_PARAM_NEW); + devlink_param_notify(devlink, NULL, param_item, DEVLINK_CMD_PARAM_NEW); return 0; err_xa_insert: @@ -628,7 +629,7 @@ static void devlink_param_unregister(struct devlink *devlink, param_item = devlink_param_find_by_id(&devlink->params, param->id); if (WARN_ON(!param_item)) return; - devlink_param_notify(devlink, 0, param_item, DEVLINK_CMD_PARAM_DEL); + devlink_param_notify(devlink, NULL, param_item, DEVLINK_CMD_PARAM_DEL); xa_erase(&devlink->params, param->id); kfree(param_item); } @@ -789,7 +790,7 @@ void devl_param_driverinit_value_set(struct devlink *devlink, u32 param_id, param_item->driverinit_value = init_val; param_item->driverinit_value_valid = true; - devlink_param_notify(devlink, 0, param_item, DEVLINK_CMD_PARAM_NEW); + devlink_param_notify(devlink, NULL, param_item, DEVLINK_CMD_PARAM_NEW); } EXPORT_SYMBOL_GPL(devl_param_driverinit_value_set); @@ -828,6 +829,6 @@ void devl_param_value_changed(struct devlink *devlink, u32 param_id) param_item = devlink_param_find_by_id(&devlink->params, param_id); WARN_ON(!param_item); - devlink_param_notify(devlink, 0, param_item, DEVLINK_CMD_PARAM_NEW); + devlink_param_notify(devlink, NULL, param_item, DEVLINK_CMD_PARAM_NEW); } EXPORT_SYMBOL_GPL(devl_param_value_changed); -- 2.50.0