Re: [Buildroot] [PATCH 1/1] package/libcddb: Fix build with gcc-14

From: David Laight <david.laight.linux@gmail.com>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org,
	Julien Boibessot <julien.boibessot@armadeus.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/libcddb: Fix build with gcc-14
Date: Sun, 6 Jul 2025 11:42:10 +0100	[thread overview]
Message-ID: <20250706114210.1669ea00@pumpkin> (raw)
In-Reply-To: <20250706101044.840248-1-bernd@kuhls.net>

On Sun,  6 Jul 2025 12:10:44 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Fixes:
> https://autobuild.buildroot.net/results/723/7236cf5fd4f33aabd3178586f877dff04d754abe/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/libcddb/0001-gcc14.patch | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 package/libcddb/0001-gcc14.patch
> 
> diff --git a/package/libcddb/0001-gcc14.patch b/package/libcddb/0001-gcc14.patch
> new file mode 100644
> index 0000000000..fe06d2512d
> --- /dev/null
> +++ b/package/libcddb/0001-gcc14.patch
> @@ -0,0 +1,24 @@
> +Fix build with gcc-14
> +
> +https://bugs.gentoo.org/919280
> +https://src.fedoraproject.org/rpms/libcddb/blob/rawhide/f/pointer-types.patch
> +
> +Patch downloaded from
> +https://gitweb.gentoo.org/repo/gentoo.git/tree/media-libs/libcddb/files/libcddb-1.3.2-c99.patch?id=9200fde5b926191737a8380a08cffa2998013945
> +
> +Upstream: https://sourceforge.net/p/libcddb/patches/9/
> +
> +Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> +
> +--- a/lib/cddb_net.c
> ++++ b/lib/cddb_net.c
> +@@ -329,7 +329,7 @@
> +             default:
> +                 /* we got connected, check error condition */
> +                 l = sizeof(rv);
> +-                getsockopt(sockfd, SOL_SOCKET, SO_ERROR, &rv, &l);
> ++                getsockopt(sockfd, SOL_SOCKET, SO_ERROR, &rv, (socklen_t * restrict)&l);

That can't really be right.
You need to change the type of 'l' to be the same as socklen_t.
If the sizes of the integer types differ then you've either passes the
wrong value (typical for big endian) or corrupted stack.

	David

> +                 if (rv) {
> +                     /* something went wrong, simulate normal connect behaviour */
> +                     errno = rv;
> +

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot